search

mattmikolay / chip-8

A collection of CHIP-8 programs and documentation
MIT License
294 stars 10 forks source link

Typo in section "All about data registers" #8

Closed leonard-9500 closed 3 years ago

leonard-9500 commented 3 years ago

In the mentioned section below the sentence:

"The bits of a data register can also be shifted to the left or to the right using the following instructions:"

The instruction 8XY1 does not match it's description in the table.

According to the page "Chip-8 Instruction Set", the instruction 8XYE, as opposed to 8XY1, allows to "Store the value of register VY shifted left one bit in register VX". The instruction 8XY1 is said to "Set VX to VX OR VY"

Sources https://github.com/mattmikolay/chip-8/wiki/Mastering-CHIP%E2%80%908#all-about-data-registers https://github.com/mattmikolay/chip-8/wiki/CHIP%E2%80%908-Instruction-Set

mattmikolay commented 3 years ago

Good catch! Thanks for reporting this. I just fixed this in the Mastering CHIP-8 doc in the wiki.