search

mattmilburn / strapi-plugin-menus

A plugin for Strapi CMS to customize the structure of menus and menu items.
MIT License
110 stars 27 forks source link

Incompatible with Strapi v4.13.1 #124

Closed mattmilburn closed 11 months ago

mattmilburn commented 1 year ago

In Strapi's latest version 4.13.1, an error occurs which seems related to React v18.

Currently unsure what is specifically causing this.

Screenshot 2023-09-01 at 3 35 23 PM
damian-balas commented 11 months ago

@mattmilburn Hi, you need to update
"react": "^17.0.2", to "react": "^18.2.0",

in your package.json

I've added yarn resolutions with v18 and it started without this error.

mattmilburn commented 11 months ago

@mattmilburn Hi, you need to update "react": "^17.0.2", to "react": "^18.2.0",

in your package.json

I've added yarn resolutions with v18 and it started without this error.

Hi @damian-balas I've been testing locally and it's true that using "resolutions": { "react": "^18.0.0" } in my Strapi app works as you described and it's a quick solution for now 🎉

However, if I update the react dependency in the menus plugin then add it back into a Strapi app, it still gets this react-dom/client error. So far I've only been able to resolve it with the resolutions prop in my Strapi app package.json as you suggested and I'm still unable to implement a solution in the plugin itself.

Oddly enough, this doesn't happen with any of my other plugins 🤷🏻‍♂️

mattmilburn commented 11 months ago

@damian-balas This issue is now fixed in the latest v1.5.0 of this plugin 👍🏻