search

mattn / anko

Scriptable interpreter written in golang
http://play-anko.appspot.com/
MIT License
1.45k stars 120 forks source link

For Go 1.12 and newer convertMap uses MapRange #321

Closed MichaelS11 closed 4 years ago

MichaelS11 commented 4 years ago

In progress

codecov-io commented 4 years ago

Codecov Report

Merging #321 into master will decrease coverage by 3.2%. The diff coverage is 97.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
- Coverage   90.45%   87.25%   -3.21%     
==========================================
  Files           8       15       +7     
  Lines        2106     2604     +498     
==========================================
+ Hits         1905     2272     +367     
- Misses        130      214      +84     
- Partials       71      118      +47
Impacted Files Coverage Δ
vm/vmConvertToX.go 93.87% <ø> (-0.86%) :arrow_down:
vm/vm.go 85.84% <100%> (-0.13%) :arrow_down:
vm/vmConvertToXGo112.go 100% <100%> (ø)
vm/vmExprFunction.go 77% <100%> (ø) :arrow_up:
vm/vmConvertToXNotGo112.go 100% <100%> (ø)
vm/vmExpr.go 93.5% <66.66%> (ø) :arrow_up:
env/envTypes.go 100% <0%> (ø)
ast/astutil/walk.go 46.11% <0%> (ø)
env/env.go 100% <0%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fee836a...6c92b97. Read the comment docs.

MichaelS11 commented 4 years ago

@mattn Please review and merge

mattn commented 4 years ago

LGTM, Thank you. (Sorry, I mistaken to click merge button)