search

mattn / anko

Scriptable interpreter written in golang
http://play-anko.appspot.com/
MIT License
1.45k stars 120 forks source link

Anon calls doesn't report the expr position #336

Closed dgrr closed 4 years ago

dgrr commented 4 years ago

Hello,

The anon calls (for example MemberExpr calls) don't report the expression position. Take a look here, there's nothing setting the position to the CallExpr. If you want to see a fix take a look here.

Thanks.

MichaelS11 commented 4 years ago

Want to make a PR? Can position be set on CallExpr create?

dgrr commented 4 years ago

I can't make a pull request because my fork is incompatible with anko. As far as I see, the position cannot be set on CallExpr create because pos is private

MichaelS11 commented 4 years ago

If you really do want to do a PR, you can setup a new branch on your fork, pull from main Anko branch on to the new branch , then do a force push to the new branch. Then do a PR from that new branch.

MichaelS11 commented 4 years ago

https://github.com/mattn/anko/pull/340