Closed Matts966 closed 2 years ago
Could you please explain your use case?
@mattn
For example, I want to use .
as hover-char
to get keywords such as a.method
and schema.table
.
efm-langserver does not provide way to key assign for the text editor. You need to setup your text editor to call hover.
Yes! I mean that char
variable!
I'm worried that this setting will cause hover to malfunction with ambiguous text. For example
Removed method foo.Bar.
@mattn You are right. This setting can cause unexpected results.
However, I think it is relatively easy to validate input texts in the hover-command
and use trimmed texts or ignore invalid texts.
This new setting will make it possible to retrieve schema of target tables, and it is easy to ignore invalid or unknown tables in that case. Showing descriptions and schema for target tables can significantly improve query writing experience. Also, I believe this setting can make other useful cases possible.
Addressed in https://github.com/mattn/efm-langserver/pull/208
Thank you! It looks great!
Add
hover-char
option for splitting words for hover information.To keep compatibility, we can use
_
as the default setting.