Option to skip linting/formatting if rootMarkers can't be resolved?

fsouza commented 2 years ago

Hi there!

Would you take a PR adding an option or something like that to allow linting/formatting/anything else if rootMarkers can't be resolved?

For example:

on textDocument/formatting, tries to find a root dir for the command using only the root markers, and if that can't be found, exit early and return the contents unchanged
on textDocument/didChange, tries to find a root dir for the command using only the root markers, and i f one can't be found, abort early and publish an empty array of diagnostics for the provided URI
do something similar for all other methods (I'd make sure the solution is generic enough without replicating the check everywhere)

What do you think? Is that feasible/acceptable? Thank you!

mattn commented 2 years ago

What you want is that efm-langserver do NOT operating linting/formatting/anything if rootMarkers can't be found. Right?

fsouza commented 2 years ago

What you want is that efm-langserver do NOT operating linting/formatting/anything if rootMarkers can't be found. Right?

Exactly. Since that would be a behavior change, I think we should do it behind a new knob. Would that be acceptable?

mattn commented 2 years ago

I don't think it's breaking behavior. I think.

mattn commented 2 years ago

Please do

fsouza commented 2 years ago

I can reuse the strategy and the config flag for textDocument/formatting. Will do that and open a PR

mattn / efm-langserver