search

mattn / efm-langserver

General purpose Language Server
MIT License
1.34k stars 61 forks source link

Replace `golint` with `golangci-lint` #231

Closed itaranto closed 1 year ago

itaranto commented 1 year ago

golangci-lint is a Go linters aggregator: https://golangci-lint.run/

golint is currently unmantained, revive attempts to be a replacement for it.

For now we only enable very basic linters + revive, more linters will be added in the future.

itaranto commented 1 year ago

For some reason the golangci-lint github action is not picking up the .golanci.yaml file on Windows.

I have no idea why...

UPDATE: All issues have been fixed, see: https://github.com/golangci/golangci-lint-action/issues/583

mattn commented 1 year ago

LGTM. Ready to merge?

itaranto commented 1 year ago

LGTM. Ready to merge?

Yes!

mattn commented 1 year ago

Thank you.