search

mattn / go-mastodon

mastodon client for golang
MIT License
599 stars 85 forks source link

fix go vet warnings: call to (*T).Fatalf from a non-test goroutine #166

Closed vyskocilm closed 1 year ago

vyskocilm commented 1 year ago

The goroutine started from test must not call t.Fatal, but t.Error. Adds a sync.WaitGroup to make sure all goroutines have a chance to report an error before test stops.

Similar fix to https://github.com/fsnotify/fsnotify/pull/416

codecov-commenter commented 1 year ago

Codecov Report

Base: 87.63% // Head: 87.63% // No change to project coverage :thumbsup:

Coverage data is based on head (ed8db3c) compared to base (ae97080). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #166 +/- ## ======================================= Coverage 87.63% 87.63% ======================================= Files 15 15 Lines 954 954 ======================================= Hits 836 836 Misses 74 74 Partials 44 44 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattn). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattn)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mattn commented 1 year ago

Thank you