search

mattn / go-oci8

Oracle driver for Go using database/sql
https://mattn.kaoriya.net/
MIT License
630 stars 212 forks source link

Fixed NCLOB #259

Closed MichaelS11 closed 6 years ago

MichaelS11 commented 6 years ago

Added CLOB & NCLOB tests Added OCILobCharSetForm Added sizeOfNilPointer

Using OCI OCILobRead needs argument saying if it is a SQLCS_IMPLICIT (CLOB) or SQLCS_NCHAR (NCLOB). Added OCI call to OCILobCharSetForm to get that value.

MichaelS11 commented 6 years ago

Changed err to *C.OCIError. Makes most cases easier to read and have type safety. Rename to conn, stmt, and rows

Build failed, but do not think because of any code change. Not sure why it fails sometimes. --- FAIL: TestSelectParallel (1.04s) oci8Sql_test.go:63: get rows error: query error: driver: bad connection

MichaelS11 commented 6 years ago

@mattn Any thoughts?

mattn commented 6 years ago

Thanks