search

mattn / go-oci8

Oracle driver for Go using database/sql
https://mattn.kaoriya.net/
MIT License
630 stars 212 forks source link

Set default prefetchRows to 0 and prefetchMemory to 4096 #302

Closed MichaelS11 closed 5 years ago

MichaelS11 commented 5 years ago

https://github.com/mattn/go-oci8/issues/38

MichaelS11 commented 5 years ago

@mattn Travis just needs a restart for it to pass.

mattn commented 5 years ago

Hmm, test on travis is flaky

MichaelS11 commented 5 years ago

Yeah :/

I wonder if it has something to do with alexeiled/docker-oracle-xe-11g, maybe it has bugs in it?

MichaelS11 commented 5 years ago

@mattn Any thoughts about merging this PR?

mattn commented 5 years ago

I hope to wait some consentration for changing prefetchMemory in #38.

MichaelS11 commented 5 years ago

@mattn https://github.com/mattn/go-oci8/issues/38 seems to have no new comments, could this be merged?