search

mattn / go-oci8

Oracle driver for Go using database/sql
https://mattn.kaoriya.net/
MIT License
630 stars 212 forks source link

library version changed to 18.3 #314

Closed hpfousac closed 5 years ago

hpfousac commented 5 years ago

I made a tool compatible/compilable with newest oci8 client

MichaelS11 commented 5 years ago

This version is a little new, probably best to just leave it for now. Plus, if the version is going to change, probably should update all the versions (readme).

cjbj commented 5 years ago

@MichaelS11 new for what? 18.3 is a renumbered 12.2.0.2 release, and 12.2 has been out since 2016. 18c itself has been out for almost a year.

MichaelS11 commented 5 years ago

Good to know. Note that it still is the newest client version out there. I say leave it to the one version older for now. But either way, people can use whatever version they want anyways (unless it is very old).

The main point is if the version is going to change, change it in all the places/files, not just that one file.

cjbj commented 5 years ago

@MichaelS11 currently it is two older :)

MichaelS11 commented 5 years ago

Getting all the version numbers to match: https://github.com/mattn/go-oci8/pull/321

MichaelS11 commented 5 years ago

https://github.com/mattn/go-oci8/pull/321 moves it to version 12.2, which I think is good for now. Close this?

MichaelS11 commented 5 years ago

@mattn Close this?

mattn commented 5 years ago

Please reoepn this if you still have an issue.

hpfousac commented 5 years ago

Thanks. Version 12.2. is good for me

On Mon, Jan 21, 2019 at 2:22 AM mattn notifications@github.com wrote:

Please reoepn this if you still have an issue.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mattn/go-oci8/pull/314#issuecomment-455921883, or mute the thread https://github.com/notifications/unsubscribe-auth/Ant_E-NsuSEjJKrfHAv0d6OXYBKtOZdEks5vFRZbgaJpZM4ZplD5 .