search

mattn / go-oci8

Oracle driver for Go using database/sql
https://mattn.kaoriya.net/
MIT License
630 stars 212 forks source link

Double max size buffer for strings #317

Closed MichaelS11 closed 5 years ago

MichaelS11 commented 5 years ago

https://github.com/mattn/go-oci8/issues/306

MichaelS11 commented 5 years ago

Waiting for confirmation from https://github.com/mattn/go-oci8/issues/306

MichaelS11 commented 5 years ago

@mattn Good to merge

cjbj commented 5 years ago

12.2 has OCI_ATTR_MAX_CHARSET_RATIO and OCI_ATTR_MAX_NCHARSET_RATIO to help in these situations.

MichaelS11 commented 5 years ago

Thank you @cjbj , good to know. Will look to add that in later.

MichaelS11 commented 5 years ago

@mattn Can you merge this?

MichaelS11 commented 5 years ago

@mattn ?

mattn commented 5 years ago

Sorry. Thanks!