search

mattn / go-oci8

Oracle driver for Go using database/sql
https://mattn.kaoriya.net/
MIT License
630 stars 212 forks source link

fix bug: return value OCI_SUCCESS_WITH_INFO #334

Closed button-chen closed 5 years ago

button-chen commented 5 years ago

I refer to the qt source code package oci part（version: 4.8.5 file: qsql_oci.cpp line: 2221）, it should be like this. And the previous if result != C.OCI_SUCCESS || result == C.OCI_SUCCESS_WITH_INFO does not conform to normal logic

MichaelS11 commented 5 years ago

Thank you

@mattn Looks good to me.

mattn commented 5 years ago

Thanks