search

mattn / go-runewidth

wcwidth for golang
MIT License
609 stars 94 forks source link

Optimize speed #22

Closed markus-oberhumer closed 6 years ago

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 98.758% when pulling 9b9ab2ee4c93d2155f1bf093b57fe233b138dd19 on markus-oberhumer:optimize-speed into e2d73ac2237ade1266fd3667a39f9cf31c7799ff on mattn:master.

markus-oberhumer commented 6 years ago

Just FYI, a follow-up commit will optimize ("compact") the neutral table.

mattn commented 6 years ago

Thanks. One thing, please remove Makefile since I hope that go-runewidth works on any system that doesn't install make command.

markus-oberhumer commented 6 years ago

Hi, I've created a new version of this pull request that is rebased to current master and removes the Makefile.

JFYI, I usually like simple Makefiles because these give you a quick clue how to build or test a package without having to read the docs...

mattn commented 6 years ago

Yes, I understand. Thank you. Just I'm thinking if we add Makefile, someone may think go-runewidth require make command for docker image.

mattn commented 6 years ago

Thanks.