mattn / go-runewidth

wcwidth for golang
MIT License
608 stars 94 forks source link

Minor cleanups #37

Closed markus-oberhumer closed 4 years ago

markus-oberhumer commented 4 years ago

Assorted minor cleanups. NFC.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 4bd49add3f73372039653b9d4214775fcf73f867 on markus-oberhumer:minor-cleanups into 18c3d09a134a52720932bbaa92c798a0ab111004 on mattn:master.

mattn commented 4 years ago

Thank you. Could you please insert this into .travis.yml ?

 script:
    - go generate
markus-oberhumer commented 4 years ago

Are you sure that re-generating the files each time in Travis is a good idea?

I think this should be handled manually.

mattn commented 4 years ago

Adding git diff also might be useful.

markus-oberhumer commented 4 years ago

Well, then please merge this and change .travis.yml to your liking.

mattn commented 4 years ago

Thank you