search

mattn / go-tty

MIT License
208 stars 18 forks source link

enable control flow; without this ctrl-s and ctrl-q are not respected #27

Closed SwampDragons closed 4 years ago

SwampDragons commented 4 years ago

Hi! Having the IXON flag as part of this bitmask has caused the following issue for me:

https://github.com/hashicorp/packer/issues/8222

This PR solves the issue for me, but I'm also wondering more generally why you're overriding the termios flags by default instead of keeping them how they already were during the program run (I do not claim to be a termios expert, so there's probably a very good reason). Another possibility that I'd be happy to implement if you're interested would to be to add some parameters to the Open call that determines what iflags to set, if you think that's a better solution.

azr commented 4 years ago

Nice change !

mattn commented 4 years ago

Thank you