Closed laysakura closed 8 years ago
I'm trying to find a solution to the test failure... (correct way to get Go version in runtime)
@laysakura これを使って貰っていいでしょうか? https://github.com/mattn/gover
早すぎる...w 了解です! 少々お待ちください。
go1.4.0 でなく go1.4 を返しますが、問題ないでしょうか?無ければマージします。
@mattn
go1.4.0 でなく go1.4 を返しますが、問題ないでしょうか?
問題ないです。下記確認しています。
ver14, _ := version.NewVersion("1.4")
ver140, _ := version.NewVersion("1.4.0")
ver150, _ := version.NewVersion("1.5.0")
fmt.Println(ver140.Equal(ver14)) // => true
fmt.Println(ver150.GreaterThan(ver14)) // => true
Thank you
@mattn Go 1.6 supports vendoring by default, so
GO15VENDOREXPERIMENT
env should not be required to usevendor/
directory.Previously, gom uses
_vendor/
directory even with Go version is 1.6+. See: http://akirachiku.com/2016/03/01/go16-development.html#vendoring (Japanese)gom should use
vendor/
directory with Go 1.6+ by default. But whenGO15VENDOREXPERIMENT=0
is explicitly set with Go<= 1.6 && >1.7
, gom should use_vendor/
(orGOM_VENDOR_NAME
when it's set) because vendoring is not supported by Go itself.Quote from https://golang.org/doc/go1.6#go_command :