mattn / mruby-onig-regexp

mrbgem of 鬼雲's Regular Expression
31 stars 36 forks source link

Problems finding oniguruma.h #76

Closed hone closed 6 years ago

hone commented 7 years ago

Every since #52, I've been having problems building this library in my mruby-cli project. It can't seem to find "oniguruma.h". I'm using mruby 1.2.0. Reverting to the previous commit fixes it for me.

CC    build/mrbgems/mruby-onig-regexp/src/mruby_onig_regexp.c -> build/host/mrbgems/mruby-onig-regexp/src/mruby_onig_regexp.o
/home/mruby/code/mruby/build/mrbgems/mruby-onig-regexp/src/mruby_onig_regexp.c:44:23: fatal error: oniguruma.h: No such file or directory
 #include "oniguruma.h"
ksss commented 7 years ago

I reproduced this issue.

** Execute /home/mruby/code/mruby/build/mrbgems/mruby-onig-regexp/src/mruby_onig_regexp.c
** Invoke /home/mruby/code/mruby/build/mrbgems/mruby-onig-regexp/src/mruby_onig_regexp.c (first_time)
** Invoke mruby_onig_regexp_with_compile_option
** Invoke /home/mruby/code/mruby/build/host/mrbgems/mruby-onig-regexp/onigmo-6.1.1/.libs/libonigmo.a
** Execute /home/mruby/code/mruby/build/mrbgems/mruby-onig-regexp/src/mruby_onig_regexp.c
** Invoke /home/mruby/code/build_config.rb (not_needed)
** Invoke /home/mruby/code/mruby/build/mrbgems/mruby-onig-regexp/mrbgem.rake (first_time, not_needed)
** Execute /home/mruby/code/mruby/build/host/mrbgems/mruby-onig-regexp/src/mruby_onig_regexp.o
"clang" -g -std=gnu99 -O3 -Wall -Werror-implicit-function-declaration -Wdeclaration-after-statement -Wwrite-strings -g3 -O0 -DMRB_DEBUG -DMRBGEM_MRUBY_ONIG_REGEXP_VERSION=0.0.0 -I"/home/mruby/code/mruby/include" -MMD -o "/home/mruby/code/mruby/build/host/mrbgems/mruby-onig-regexp/src/mruby_onig_regexp.o" -c "/home/mruby/code/mruby/build/mrbgems/mruby-onig-regexp/src/mruby_onig_regexp.c"
/home/mruby/code/mruby/build/mrbgems/mruby-onig-regexp/src/mruby_onig_regexp.c:44:10: fatal error: 'oniguruma.h' file not found
#include "oniguruma.h"

It seems there is no HAVE_ONIGMO_H.

But mruby_onig_regexp_with_compile_option task was invoked.

And, mruby master branch doesn't reproduce it.

take-cheeze commented 7 years ago

This should be fixed in 1.3(as I know) and the reason is that

So we need to find onigmo.h with search_header_path for mruby 1.2. Though we should move to 1.3 so this can be "won't fix".