search

mattn / mruby-uv

interface to libuv for mruby(experimental)
http://mattn.kaoriya.net/
92 stars 25 forks source link

Refactor getaddrinfo. #77

Closed take-cheeze closed 7 years ago

take-cheeze commented 7 years ago
mattn commented 7 years ago

Oh, good. Please wait for my checking.

mattn commented 7 years ago

Build error on Windows.

https://gist.github.com/eba471dd637c61afc877f6b055e11251

mattn commented 7 years ago

Could you please add this?

diff --git a/src/mrb_uv.c b/src/mrb_uv.c
index 73ab6cf..35a8a08 100644
--- a/src/mrb_uv.c
+++ b/src/mrb_uv.c
@@ -1,3 +1,4 @@
+#define _WIN32_WINNT 0x0600
 #include "mruby/uv.h"
 #include "mrb_uv.h"

I'm okay adding compiler flag instead.

mattn commented 7 years ago

LGTM (if you add change I mentioned). Tests passed.

take-cheeze commented 7 years ago

Those flags is from: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/netdb.h.html Though I don't think all of them is required so I'll remove them. Does _WIN32_WINNT still required when I removed AI_NUMERICSERV, AI_V4MAPPED, AI_ALL, AI_ADDRCONFIG?

take-cheeze commented 7 years ago

@mattn Removed 4 constants.

mattn commented 7 years ago

Does _WIN32_WINNT still required when I removed AI_NUMERICSERV, AI_V4MAPPED, AI_ALL, AI_ADDRCONFIG?

If add _WIN32_WINNT >= 0x0600, compilation error is removed. I want to keep it on Windows.

take-cheeze commented 7 years ago

@mattn reverted constants remove and added _WIN32_WINNT define.

mattn commented 7 years ago

Thank you. I'll look it after takoyaki party.

On 9/23/17, Takeshi Watanabe notifications@github.com wrote:

@mattn reverted constants remove and added _WIN32_WINNT define.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/mattn/mruby-uv/pull/77#issuecomment-331619469

--

take-cheeze commented 7 years ago

🐙

mattn commented 7 years ago

Thanks! :octocat: