mattn / vim-lsp-settings

Auto configurations for Language Server for vim-lsp
MIT License
1.26k stars 225 forks source link

Java's eclipse-jdt-ls does not offer suggestions after a dot #725

Closed danirod closed 3 months ago

danirod commented 4 months ago

I believe that there is an error in the way refresh_pattern is set for eclipse-jdt-ls, that prevents complete suggestions to be shown after a dot has been typed (such as using the dot to access the methods of an instance variable).

The refresh pattern was originally set in https://github.com/mattn/vim-lsp-settings/pull/490. Other issues in vim-lsp and vim-lsp-settings seem to be pointing to this:

As seen in the following case, while suggestions work after typing a dot in the import statement, typing a dot inside a method body does not present suggestions.

https://github.com/mattn/vim-lsp-settings/assets/1568690/3341b00b-9a09-44b2-b6c7-3bb0188f9f29

Patching the refresh_pattern for eclipse-jdt-ls and removing the dot as proposed in the patch causes dots to always trigger the completion menu, both on imports and on method bodies:

https://github.com/mattn/vim-lsp-settings/assets/1568690/66cf953e-5c6e-41f7-ba78-cea96cdebb68

I know little about Vim patterns and their differences in regard to normal PCRE patterns and while the fix seems to work and is aligned with the experience of other people in issues linked above, I'm scared about unexpected consequences of changing this.

mattn commented 3 months ago

Thank you