search

mattnedrich / MeanShift_py

Simple implementation of mean shift clustering in python
MIT License
293 stars 100 forks source link

Absolute imports or PIP package? #9

Open jembezmamy opened 6 years ago

jembezmamy commented 6 years ago

Hi,

I don't use Python on regular basis, so maybe I don't understand something here, but how exactly am I supposed to include your code in my project? Usually I load stuff with PIP, but it seems that you haven't publish PIP package for this repo.

So I tried using git submodule and it seems ok, but I've got a problem with absolute imports - I use Python 3 so statements like import point_grouper as pg won't work unless I include your code in my project root directory - which would be so hacky. :smile:

I think this could by fixed by replacing import lines with something like from . import point_grouper as pg. What do you think about this?

I feel that PIP package would be more elegant solution.

mattnedrich commented 4 years ago

This is a great point. Sorry for responding a year and a half late. I'm not really able to actively maintain this repo or respond to issues very well. I'll see if I'm able to turn this into a package.