mattnenterprise / rust-ftp

FTP client for Rust
Apache License 2.0
182 stars 57 forks source link

Make the code more ergonomic #56

Closed matt2xu closed 7 years ago

matt2xu commented 7 years ago

Taking a new look at this crate after several months, it's looking great! I have a few ideas to make the code more ergonomic, for instance replacing explicit drops by out-of-scope automatic drops, using AsRef<&str> or Into<Cow<'a, str>>, rewriting simpleretr to avoid a clone, this kind of things. Would you be interested in a PR with these changes?

mattnenterprise commented 7 years ago

Go for it!