search

mattnenterprise / rust-ftp

FTP client for Rust
Apache License 2.0
182 stars 57 forks source link

Add more tests #60

Closed matt2xu closed 7 years ago

matt2xu commented 7 years ago

This aims to solve #27 and allow us to test we don't break anything when refactoring (related to @mattnenterprise 's question in #59 ).

This PR is mainly about improving the test infrastructure so we have an FTP server that is configured both for login with write access and for anonymous read-only access, which I believe is quite standard as a configuration and allow us to test both modes.

Now we have a Dockerfile for testing during development in addition to the .travis.yml file used by Travis CI when pushing.

I also fixed a couple of documentation examples failing tests, and improved the main test to make it repeatable. After this PR is merged, I intend to add more documentation tests.

matt2xu commented 7 years ago

Note: I can squash all commits if you prefer

mattnenterprise commented 7 years ago

This will help a lot with keeping this library bug free! Thank you for all the work!