search

mattnenterprise / rust-ftp

FTP client for Rust
Apache License 2.0
182 stars 57 forks source link

rust-OpenSSL 0.7 does not compile on latest Linux #63

Open glennpierce opened 7 years ago

glennpierce commented 7 years ago

Can we update [dependencies.openssl] to rust-OpenSSL 0.9 ?

0.7 no longer compiles on the latest Fedora / Linux

Luxed commented 7 years ago

openssl has changed between version 0.7 and 0.9, I will make a pull request to correct an issue that I have with the list and nlst functions. I will take a shot at updating openssl too. I don't really need it because I am on Ubuntu 16.04 but I didn't try to compile on my arch linux machine.

I'll keep you updated on that.

mattnenterprise commented 7 years ago

@Luxed: How about using native-tls ? I believe it has better portability.

Luxed commented 7 years ago

The patch is coming but it's harder than I thought to be honest :/ The way the stream is initialized has completely changed and I do not currently know if my patch will work :/

Anyways, I'm rewriting the connection part for the secure ftp, hoping to get things into a PR tomorrow (a working one this time maybe)

My primary focus is that because I wanted to try on my laptop (where I like to do my testing because I can destroy it, I don't care, I have 10 linux distros on the thing)

Edit 1: Lifetimes are a pain in the ass... I'm having troubles figuring out how to make it work... @mattnenterprise I looked at native-tls, it looks exactly like openssl 0.9 so the conversion won't difficult at all.