search

mattnenterprise / rust-ftp

FTP client for Rust
Apache License 2.0
182 stars 57 forks source link

ftp list function only returning a String #70

Open Luxed opened 7 years ago

Luxed commented 7 years ago

This one is only for ease of use: It would be great if the list function return a Struct containing all of the information in the String.

I will do yet another pull request adding the code that I made for this, but I would like the openssl issue #69 to be resolved first because the list function doesn't work without this update.

Luxed commented 6 years ago

This is ready on my fork (because I needed it), but I won't create a PR until #69 isn't merged because it is based on that.

benjaminbours commented 5 years ago

@Luxed Can you please create a PR ? This feature interest me also 😃

Luxed commented 5 years ago

@benjaminbours Well... This is 2 years old now. I looked at my branch and I'm not that happy about what I did. I don't like the fact that everything is based on the given string, so if the returned string doesn't have a fixed format, this entire module would break. If are willing to make the PR yourself, the changes are on my branch, feel free to fork/merge that into your branch, fix everything up and test to see if this still works.

benjaminbours commented 5 years ago

It's ok forget it 😄By the time, I checked specification about FTP and it seems there is no official specification about the response format of the LIST command.

Here are some useful ressources I found about it during my search => https://files.stairways.com/other/ftp-list-specs-info.txt

http://cr.yp.to/ftpparse.html => This one could be a Rust crate by itself, it seems to cover most of the case and I think FileZilla use it for exemple.

Fenex commented 3 years ago

I have created a crate that can parse FTP-server's answer (LIST command): ftp-cmd-list-parse