search

mattnenterprise / rust-ftp

FTP client for Rust
Apache License 2.0
182 stars 57 forks source link

Allow the stream to be anything that implements Read and Write #9

Open mattnenterprise opened 8 years ago

matt2xu commented 8 years ago

What is the problem of the current implementation using a TcpStream explicitly?

mattnenterprise commented 8 years ago

Nothing is wrong with the current implementation. Another issue was opened in another project of mine that asked for this kind of functionality. https://github.com/mattnenterprise/rust-imap/issues/3 I don't think it should be done for this project unless someone requests it. I think the current implementation is just fine.

matt2xu commented 8 years ago

Ok I see. I think it would be more difficult than for IMAP though, because of FTP's passive mode. I'd say another solution might be to support SOCKS proxying instead with the "socks" crate. Anyway, I agree with you, we can wait until somebody needs this.