search

mattnenterprise / rust-pop3

POP3 client for Rust
MIT License
31 stars 13 forks source link

implement a function to send UIDL command #2

Closed hebiyan closed 9 years ago

hebiyan commented 9 years ago

Since this library seems to lack the implementation of UIDL command. So I wrote functions that send the UIDL command and that parse the response from server, based on rfc1939. Please check my code.

Sorry for my poor english. Thank you.

mattnenterprise commented 9 years ago

First of all thanks for the pull request! Second Its looks to me as the functions parse_uidl_all and parse_uidl_one do the same thing except for the regex definition. Could you split out the common functionality into a function where you just pass in the regex?

mattnenterprise commented 9 years ago

LGTM. Thanks for the pull request!

hebiyan commented 9 years ago

Thank you for merging this! I'm happy to help you.