search

mattogodoy / hacker-sounds

This Visual Studio Code extension automatically turns you into a very skilled hacker by playing movie-like sounds while you write code.
GNU General Public License v3.0
54 stars 25 forks source link

mplayer flag on Ubuntu is not required/does not replicate the original .wav sound? #16

Closed raihaan123 closed 3 years ago

raihaan123 commented 3 years ago

Hi, great extension you have going on here! - I'm running Ubuntu 20.04 and I noticed the effects were not playing properly for me, instead getting these uncomfortably loud noises... Still haven't figured out where that was coming from, but digging into the issue I noticed that in player.js you were calling mplayer with the -af flag, which I couldn't replicate on the terminal.

Deleting the flag from player.js, the sound effects work perfectly. Not sure if I've had a unique issue but thought I'd drop a note here. Cheers

mattogodoy commented 3 years ago

Hello! Thanks for the report and the investigation! I currently don't have Ubuntu installed, but I have a couple of friends that do. I'll test with them and report back to this same issue. If removing the flag is the solution, I'll upload a new version to the marketplace.

Thanks!

mattogodoy commented 3 years ago

Sorry for the long delay. I finally checked this in a friend's laptop with a freshly installed Ubuntu 21 and everything worked as expected! Also, I remembered the use of the -af flag: it's necessary to change the reproduction volume (https://linux.die.net/man/1/mplayer).

What this means is that I will not change this for now, unless there are more users with the same problem and I can reproduce the issue to be able to fix it.

I hope it works ok for you with the changes you have already made :)