search

mattolenik / hclq

Command-line processor for HashiCorp config files, like sed for HCL — Terraform, Consul, Nomad, Vault
https://hclq.sh
The Unlicense
254 stars 23 forks source link

fixing #6. Drop the shorthand to resolve panic #7

Closed ghost closed 5 years ago

ghost commented 5 years ago

remove the shorthand so it doesn't conflict with the global option. fixes #6

sebbrandt87 commented 5 years ago

maybe an "I" would be possible instead of removing it fully ;) or "r" for replace.

ghost commented 5 years ago

But is I an "capital i" or a "lowercase L” ;-)

On 8. Apr 2019, at 17:51, Sebastian Brandt notifications@github.com wrote:

maybe an "I" would be possible instead of removing it fully ;) or "r" for replace.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mattolenik/hclq/pull/7#issuecomment-480890043, or mute the thread https://github.com/notifications/unsubscribe-auth/Afzwq1-E2c4BR47c9tOKjEofrhFkf6F9ks5ve2WFgaJpZM4ccU6g.

-- This email and any attachments thereto contain private, confidential, and  privileged material. Any use, review, copying, or disclosure of this email (or any attachments thereto) by any party other than the intended recipient is strictly prohibited. If you are not the intended recipient, please contact the sender immediately and permanently delete the original and any copies of this email and any attachments. AllCloud GmbH, Prinzregentenstrasse 78 ℅ DWF, Registergericht 81675 München, HRB 228227, Geschäftsführer: Ronit Rubin

sebbrandt87 commented 5 years ago

fur sure an uppercase "i" 🎉 ;) @mattolenik what is you opinion?

mattolenik commented 5 years ago

Heh, I debated removing short options because of ambiguity, this settles it! Let's just do no shorthand, it's the most clear. Thanks for the PR!