search

mattosaurus / ChartJSCore

Implementation of Chart.js for use with .NET Core.
GNU General Public License v3.0
116 stars 34 forks source link

Development proposal for #70 and #71 #72

Closed bcanteneurEiffage closed 2 years ago

bcanteneurEiffage commented 2 years ago

Here is a proposal for Issue #70 and Issue #71

mattosaurus commented 2 years ago

Hi, thanks for this.

Are you using v2 or v3 of Chart.js? This library currently only works with v2 (though I've been meaning to upgrade it) so if you're using v3 then you may have other issues as well.

I'm happy to accept this PR as it looks like this applies to both v2 and v3.

bcanteneurEiffage commented 2 years ago

Oh ... my bad! Did not see that the library worked only with v2 and I referenced v3.7 from Chart.js Not sure it is going to work with v2, I would have to test it

Thanks for the review of the code 👍

mattosaurus commented 2 years ago

I'm hoping to finally mange to update it to v3 this week or next so when I don I'll incorporate your code.