search

mattosaurus / ChartJSCore

Implementation of Chart.js for use with .NET Core.
GNU General Public License v3.0
116 stars 34 forks source link

GridLines renamed in v3 #77

Open SaltySeaSlug opened 2 years ago

SaltySeaSlug commented 2 years ago

Hi,

Just want to bring to your attention;

GridLines has been renamed in Chart.js v3.x to Grid along with a few other changes in property names

https://www.chartjs.org/docs/3.7.1/getting-started/v3-migration.html#ticks

mattosaurus commented 2 years ago

Hi, thanks for pointing that out. I think I've updated all the relevant properties now and have published v3.1.0 with the changes but let me know if you spot anything else I've missed.

SaltySeaSlug commented 2 years ago

Hi,

Noticed that common properties for axes are missing from your scale base; Few were removed from the Tick and Time classes respectively;

scales.[x/y]Axes.ticks.beginAtZero was renamed to scales[id].beginAtZero

/ MERGED PROPERTIES / scales.[x/y]Axes.ticks.max was renamed to scales[id].max scales.[x/y]Axes.ticks.min was renamed to scales[id].min scales.[x/y]Axes.time.max was renamed to scales[id].max scales.[x/y]Axes.time.min was renamed to scales[id].min

scales.[x/y]Axes.ticks.reverse was renamed to scales[id].reverse scales.[x/y]Axes.ticks.suggestedMax was renamed to scales[id].suggestedMax scales.[x/y]Axes.ticks.suggestedMin was renamed to scales[id].suggestedMin

https://www.chartjs.org/docs/3.7.1/axes/#common-options-to-all-axes

mattosaurus commented 2 years ago

Thanks, the axes had changed more than I'd expected. I've updated these and pushed out v3.2.0.