search

mattosaurus / ChartJSCore

Implementation of Chart.js for use with .NET Core.
GNU General Public License v3.0
116 stars 34 forks source link

Added missing position property, Legend plugin #96

Closed stephanstapel closed 1 year ago

stephanstapel commented 1 year ago

sorry for asking this after issuing the pull request: I saw that precision, position and stepsize are members of CartesianLinearTick whereas I added them to Tick class. Wondering which approach is correct here?

mattosaurus commented 1 year ago

Hi, is it not possible to do all of this using the PluginDynamic property rather than adding these additional properties?

I don't really want to add the onclick method to the code as that's something that should be defined by the user rather than in the code base.

stephanstapel commented 1 year ago

Hi, of course I can add this as a plugin dynamic. I thought sharing it with other users as a dedicated plugin could be nice for everybody!

stephanstapel commented 1 year ago

updated readme!

stephanstapel commented 1 year ago

Hi @mattosaurus , I just wanted to ask if there is anything I could to do get this pull request accepted. At least the legend plugin is quite nice for a lot of people I think since it allows you to invert the legend click behaviour (which is a bit counter-intuitive in standard ChartJS)

mattosaurus commented 1 year ago

Sorry, I lost track of this. I've published a new v3.10.1 version of this now.