mattpannella / pupdate

Pupdate - A thing for updating your Analogue Pocket
https://mattpannella.github.io/pupdate/
MIT License
1.07k stars 38 forks source link

Game And Watch: uncaught exception prevents skipping errors #191

Closed timotheeg closed 1 year ago

timotheeg commented 1 year ago

Describe the bug I've downloaded roms and artwork for game and watch stuff, but it seems I might not have retrieved the correct files (how do I know? 😢)

So when I run Generate Game and Watch ROMS, an error occured and the process just stops. I know some of the assets are correct because 2 are processed successfully before it stops, but the program is not attempting all. It stops on first error.

To Reproduce I'm not sure if I can link to where I got the roms and artwork files (Let me know). Just for generic info, I grabbed the roms from mame 0.217 set on archive.org, and the artworks from a publicly shared google drive folder

At any rate, I followed the instructions, and then from the menu I selected [6] Generate Game and Watch ROMS

Expected behavior Skip errors Process all that can be processed Report errors last

Bonus: Provide instructions on how to identify "good" rom and artwork files.

Screenshots No screenshot, but this is the output I got:

Executing /Volumes/A-POCKET/tools/gameandwatch/mac/fpga-gnw-romgenerator
-------------------------
Processing device gnw_ball

Ignoring element by name Bubbles
Successfully created device gnw_ball at /Volumes/A-POCKET/Assets/gameandwatch/common/Ball.gnw

-------------------------
Processing device gnw_cgrab

Could not open expected ROM file ("gnw_cgrab.zip") at "/Volumes/A-POCKET/Assets/gameandwatch/agg23.GameAndWatch/roms/gnw_cgrab.zip"
Failing device gnw_cgrab

-------------------------
Processing device gnw_chef

Successfully created device gnw_chef at /Volumes/A-POCKET/Assets/gameandwatch/common/Chef.gnw

-------------------------
Processing device gnw_dkjr

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Custom { field: "unknown variant `bounds x=\"0\" y=\"0\" width=\"1222\" height=\"798\" />`, expected one of `bounds`, `element`, `overlay`, `screen`" }', src/layout.rs:169:80
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Desktop (please complete the following information):

Contents of settings file

{
  "firmware": {
    "version": "pocket_firmware_B_9.bin"
  },
  "config": {
    "download_assets": true,
    "archive_name": "openFPGA-Files",
    "github_token": null,
    "download_firmware": true,
    "core_selector": false,
    "preserve_platforms_folder": false,
    "delete_skipped_cores": true,
    "download_new_cores": "ask",
    "build_instance_jsons": true,
    "crc_check": true,
    "fix_jt_names": true,
    "skip_alternative_assets": true,
    "use_custom_archive": false,
    "custom_archive": {
      "url": "https://updater.retrodriven.com",
      "index": "updater.php"
    }
  },
  "coreSettings": {
    "agg23.Arduboy": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "agg23.Pong": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "agg23.NES": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "agg23.PC Engine": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "agg23.PokemonMini": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "agg23.SNES": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "ericlewis.Asteroids": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "ericlewis.Dominos": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "ericlewis.DonkeyKong": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "ericlewis.Genesis": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "ericlewis.LunarLander": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "ericlewis.RadarScope": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "ericlewis.SpaceRace": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "ericlewis.SuperBreakout": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "ericlewis.QBert": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Mazamars312.NeoGeo": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Mazamars312.Amiga": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "nullobject.tecmo": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "boogermann.bankpanic": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "boogermann.congo": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "boogermann.digdug": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "boogermann.galaga": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "boogermann.gberet": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "boogermann.pooyan": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "boogermann.supervision": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "boogermann.xevious": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "Spacemen3.PDP1": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.GB": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.GBA": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.GBC": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.NES": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.GG": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.SMS": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.SG-1000": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.VideoBrain": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.Supervision": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.SuperGB": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.Studio2": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.Odyssey2": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.Intv": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.Megaduck": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.Genesis": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.Gameking": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.Gamate": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.Creativision": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.Coleco": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.ChannelF": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.7800": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.Arcadia": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.Adventurevision": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.2600": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "pram0d.garegga": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "pram0d.snowbros2": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtdd": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtdd2": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtgng": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtkicker": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtkunio": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtmikie": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtpinpon": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtroadf": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtroc": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtsbaskt": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jttrack": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtvigil": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtyiear": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtpang": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtcontra": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "pram0d.bakraid": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "pram0d.batrider": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "antongale.slapfight": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Mazamars312.NeoGeo_Overdrive": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "agg23.WonderSwan": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "antongale.performan": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "antongale.exerion": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtexed": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtgunsmk": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtkarnov": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtoutrun": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtcop": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtsectnz": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtsarms": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtsf": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jttrojan": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtvulgus": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "Mazamars312.PC Engine CD": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "pram0d.kingdmgp": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "pram0d.sstriker": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "agg23.GameAndWatch": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "agg23.Tamagotchi_P1": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "antongale.taitosj": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtaliens": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtbtiger": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtcastle": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtcomsc": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtcps1": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtkiwi": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtrastan": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jts16b": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtshanon": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtsimson": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jttmnt": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jttwin16": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "somhi.flappybird": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    }
  }
}
timotheeg commented 1 year ago

Never mind 😑 , I think I messed up my copy command and the artwork files ended up overwriting the rom files 🤦 . With that sorted out, The generation worked fine!

mattpannella commented 1 year ago

glad you figured it out.