mattpannella / pupdate

Pupdate - A thing for updating your Analogue Pocket
https://mattpannella.github.io/pupdate/
MIT License
989 stars 33 forks source link

PCE CD JSON is a bit of a mess #279

Closed TheSKARD1 closed 2 months ago

TheSKARD1 commented 3 months ago

Not a technical bug, I wanted to share my experience in the hope something can be improved.

Describe the bug In my pcecd common folder I have the bin/cue images in individual folders for each game. The image names do not match the folder name. The folder name is how I want the title displayed.

After running pupdate.exe and generating the json files I get the following: 4 were in the main folder. These 4 are the only ones where the image name matched the folder name. Everything else was in individual folders for each game matching my game title folders. The json files in the individual folders were named with the image name.

I wrote for myself a batch file to rename all of them to their folder name. Then I moved them into the main folder and deleted the subfolders.

Expected behavior Name json files after the folder name. Have all json files in the same folder.

lunchpacked130 commented 3 months ago

I think i have a similar issue..

All games alphabetically from "Shadow of the beast" gets put in its own folder, but all games before is where they should be.

But I will double check just to be sure, I'll come back with any findings

lunchpacked130 commented 3 months ago

I backed up all the jsons and deleted them, then ran update all to have it generate the jsons from scratch.

I can confirm that some generated jsons gets put into folders for some reason. i do have a customized folder layout for the roms, but it works with everrthing else. but for me, every game in my "1 Licensed" folder from "Shadow of the Beast" to "Zero 4 Champ 2" gets each put into a subfolder.

pupdate does not show any indication of generating some jsons inside folders.

below are the log from pupdate (truncated to just PCE CD) and a text representation of my PCE CD "Asset" folder structure:

Pupdate.exe log for PCE CD Checking Core: Mazamars312.PC Engine CD 0.1.7 is the most recent release, checking local core... Local core found: 0.1.7 Looking for Assets... Already installed: bios_3_0_usa.pce Already installed: bios_3_0_jap.pce Already installed: bios_2_0_usa.pce Already installed: bios_2_0_jap.pce Already installed: bios_1_0_jap.pce Building instance json files. Saving 'Akumajou Dracula X - Chi no Rondo (JP) (US).json'... Saving 'Baby Jo - The Super Hero (JP).json'... Saving 'Beyond Shadowgate (US).json'... Saving 'Black Hole Assault (JP).json'... Saving 'Bonk 3 - Bonk Big Adventure (US).json'... Saving 'Buster Bros (US).json'... Saving 'Camp California (US).json'... Saving 'Cosmic Fantasy 2 (US).json'... Saving 'Cotton Fantastic Night Dreams (JP).json'... Saving 'Dragon Slayer - The Legend of Heroes (US).json'... Saving 'Dungeon Explorer 2 (US).json'... Saving 'Dungeon Master - Therons Quest (US).json'... Saving 'Exile - Wicked Phenomenon (US).json'... Saving 'Exile (US).json'... Saving 'F1 Circus Special - Pole to Win (JP).json'... Saving 'Faceball (JP).json'... Saving 'Fantastic Night Dreams - Cotton (US).json'... Saving 'Final Zone 2 (US).json'... Saving 'Forgotten Worlds (US).json'... Saving 'FX Unit Yuki - The Henshin Engine (US).json'... Saving 'Gate of Thunder (JP).json'... Saving 'Gate of Thunder + Bonks Adventure + Bonks Revenge (US).json'... Saving 'Godzilla (US).json'... Saving 'Golden Axe (JP).json'... Saving 'Hawaiian Island Girls (US).json'... Saving 'Hypernova Blast (US).json'... Saving 'Implode (US).json'... Saving 'Insanity (US).json'... Saving 'It Came from the Desert (US).json'... Saving 'J. B. Harold Murder Club (US).json'... Saving 'Jack Nicklaus Turbo Golf (US).json'... Saving 'Jessie Jaeger in Cleopatras Curse (US).json'... Saving 'Jim Power in Mutant Planet (JP).json'... Saving 'John Madden Duo CD Football (US).json'... Saving 'Last Alert (US).json'... Saving 'Lemmings (JP).json'... Saving 'Loom (US).json'... Saving 'Lords of the Rising Sun (US).json'... Saving 'Lords of Thunder (US).json'... Saving 'Magical Dinosaur Tour (US).json'... Saving 'Meteor Blaster DX (US).json'... Saving 'Might and Magic 3 - Isles of Terra (US).json'... Saving 'Mirai Shounen Conan (JP).json'... Saving 'Monster Lair (US).json'... Saving 'Motoroader MC (JP).json'... Saving 'Motteke Tamago (JP) (US).json'... Saving 'Mysterious Song (US).json'... Saving 'Neo Nectaris (JP).json'... Saving 'Ookami-teki Monshou - Crest of Wolf (JP).json'... Saving 'Police Connection (JP).json'... Saving 'Pop n Magic (JP).json'... Saving 'Populous - The Promised Lands (JP).json'... Saving 'Prince of Persia (US).json'... Saving 'Puyo Puyo CD (JP).json'... Saving 'Pyramid Plunder (US).json'... Saving 'Rainbow Islands - The Story of Bubble Bobble 2 (JP).json'... Saving 'Rally Championship (JP).json'... Saving 'Revival Chase (US).json'... Saving 'Riot Zone (US).json'... Saving 'Road Spirits (JP).json'... Saving 'R-Type Complete CD (JP).json'... Saving 'Shadow of the Beast (US).json'... Saving 'Shape Shifter (US).json'... Saving 'Sherlock Holmes - Consulting Detective - Volume 2 (US).json'... Saving 'Sherlock Holmes - Consulting Detective (US).json'... Saving 'SimEarth - The Living Planet (US).json'... Saving 'Slot Gambler (JP).json'... Saving 'Splash Lake (US).json'... Saving 'Star Parodier (JP) (US).json'... Saving 'Startling Odyssey 2 - Maryuu Sensou (JP) (US).json'... Saving 'Startling Odyssey 2 (JP) (US).json'... Saving 'Super Air Zonk - Rockabilly-Paradise (US).json'... Saving 'SydMead TerraForming (US).json'... Saving 'The Addams Family (US).json'... Saving 'The Dynastic Hero (US).json'... Saving 'The Local Girls of Hawaii (US).json'... Saving 'The Manhole (JP).json'... Saving 'Valis 2 (US).json'... Saving 'Valis 3 (US).json'... Saving 'Vasteel (US).json'... Saving 'Where in the World Is Carmen Sandiego (JP).json'... Saving 'Ys 3 - Wanderers from Ys (US).json'... Saving 'Ys 4 The Dawn of Ys (JP) (dub) (US).json'... Saving 'Ys 4 The Dawn of Ys (JP) (US).json'... Saving 'Ys Book 1 and 2 (US).json'... Saving 'Zero 4 Champ 2 (JP).json'... Saving 'Mysterious Song (US).json'... Saving 'Pyramid Plunder (US).json'... Saving 'Akumajou Dracula X - Chi No Rondo (English v1.01).json'... Saving 'Ginga Ojousama Densetsu Yuna (English v1.0).json'... Saving 'Motteke Tamago (English v1.0).json'... Saving 'Startling Odyssey II (English)[TruMisery].json'... Saving 'Ys IV - The Dawn of Ys (English Text + Dub).json'... Saving 'Cosmic Fantasy 2 - Un-Worked Designs (Hack v0).json'... Saving 'Exile - Un-Worked Designs (Hack v0).json'... Saving 'Exile II - Un-Worked Designs (Hack v1).json'... Saving 'FX-Unit Yuki - The Henshin Engine.json'... Finished Up to date. Skipping core.
Analogue Pocket PCE CD Folder Structure ├───common │ │ bios_3_0_usa.pce │ │ bios_3_0_jap.org │ │ bios_2_0_usa.pce │ │ bios_2_0_jap.pce │ │ bios_1_0_jap.pce │ │ mpu.bin │ │ bios_3_0_jap.pce │ │ │ ├───1 Licensed │ │ ├───Akumajou Dracula X - Chi no Rondo (JP) (US) │ │ │ Akumajou Dracula X - Chi no Rondo (JP) (US).bin │ │ │ Akumajou Dracula X - Chi no Rondo (JP) (US).cue │ │ │ │ │ ├───Baby Jo - The Super Hero (JP) │ │ │ Baby Jo - The Super Hero (JP).bin │ │ │ Baby Jo - The Super Hero (JP).cue │ │ │ │ │ ├───Beyond Shadowgate (US) │ │ │ Beyond Shadowgate (US).bin │ │ │ Beyond Shadowgate (US).cue │ │ │ │ │ ├───Black Hole Assault (JP) │ │ │ Black Hole Assault (JP).bin │ │ │ Black Hole Assault (JP).cue │ │ │ │ │ ├───Bonk 3 - Bonk Big Adventure (US) │ │ │ Bonk 3 - Bonk Big Adventure (US).bin │ │ │ Bonk 3 - Bonk Big Adventure (US).cue │ │ │ │ │ ├───Buster Bros (US) │ │ │ Buster Bros (US).bin │ │ │ Buster Bros (US).cue │ │ │ │ │ ├───Camp California (US) │ │ │ Camp California (US).bin │ │ │ Camp California (US).cue │ │ │ │ │ ├───Cosmic Fantasy 2 (US) │ │ │ Cosmic Fantasy 2 (US).bin │ │ │ Cosmic Fantasy 2 (US).cue │ │ │ │ │ ├───Cotton Fantastic Night Dreams (JP) │ │ │ Cotton Fantastic Night Dreams (JP).bin │ │ │ Cotton Fantastic Night Dreams (JP).cue │ │ │ │ │ ├───Dragon Slayer - The Legend of Heroes (US) │ │ │ Dragon Slayer - The Legend of Heroes (US).bin │ │ │ Dragon Slayer - The Legend of Heroes (US).cue │ │ │ │ │ ├───Dungeon Explorer 2 (US) │ │ │ Dungeon Explorer 2 (US).bin │ │ │ Dungeon Explorer 2 (US).cue │ │ │ │ │ ├───Dungeon Master - Therons Quest (US) │ │ │ Dungeon Master - Therons Quest (US).bin │ │ │ Dungeon Master - Therons Quest (US).cue │ │ │ │ │ ├───Exile - Wicked Phenomenon (US) │ │ │ Exile - Wicked Phenomenon (US).bin │ │ │ Exile - Wicked Phenomenon (US).cue │ │ │ │ │ ├───Exile (US) │ │ │ Exile (US).bin │ │ │ Exile (US).cue │ │ │ │ │ ├───F1 Circus Special - Pole to Win (JP) │ │ │ F1 Circus Special - Pole to Win (JP).bin │ │ │ F1 Circus Special - Pole to Win (JP).cue │ │ │ │ │ ├───Faceball (JP) │ │ │ Faceball (JP).bin │ │ │ Faceball (JP).cue │ │ │ │ │ ├───Fantastic Night Dreams - Cotton (US) │ │ │ Fantastic Night Dreams - Cotton (US).bin │ │ │ Fantastic Night Dreams - Cotton (US).cue │ │ │ │ │ ├───Final Zone 2 (US) │ │ │ Final Zone 2 (US).bin │ │ │ Final Zone 2 (US).cue │ │ │ │ │ ├───Forgotten Worlds (US) │ │ │ Forgotten Worlds (US).bin │ │ │ Forgotten Worlds (US).cue │ │ │ │ │ ├───FX Unit Yuki - The Henshin Engine (US) │ │ │ FX Unit Yuki - The Henshin Engine (US).bin │ │ │ FX Unit Yuki - The Henshin Engine (US).cue │ │ │ │ │ ├───Gate of Thunder (JP) │ │ │ Gate of Thunder (JP).bin │ │ │ Gate of Thunder (JP).cue │ │ │ │ │ ├───Gate of Thunder + Bonks Adventure + Bonks Revenge (US) │ │ │ Gate of Thunder + Bonks Adventure + Bonks Revenge (US).bin │ │ │ Gate of Thunder + Bonks Adventure + Bonks Revenge (US).cue │ │ │ │ │ ├───Godzilla (US) │ │ │ Godzilla (US).bin │ │ │ Godzilla (US).cue │ │ │ │ │ ├───Golden Axe (JP) │ │ │ Golden Axe (JP).bin │ │ │ Golden Axe (JP).cue │ │ │ │ │ ├───Hawaiian Island Girls (US) │ │ │ Hawaiian Island Girls (US).cue │ │ │ Hawiian Island Girls (USA) (Unl).bin │ │ │ │ │ ├───Hypernova Blast (US) │ │ │ Hypernova Blast (US).bin │ │ │ Hypernova Blast (US).cue │ │ │ │ │ ├───Implode (US) │ │ │ Implode (US).bin │ │ │ Implode (US).cue │ │ │ │ │ ├───Insanity (US) │ │ │ Insanity (US).bin │ │ │ Insanity (US).cue │ │ │ │ │ ├───It Came from the Desert (US) │ │ │ It Came from the Desert (US).bin │ │ │ It Came from the Desert (US).cue │ │ │ │ │ ├───J. B. Harold Murder Club (US) │ │ │ J. B. Harold Murder Club (US).bin │ │ │ J. B. Harold Murder Club (US).cue │ │ │ │ │ ├───Jack Nicklaus Turbo Golf (US) │ │ │ Jack Nicklaus Turbo Golf (US).bin │ │ │ Jack Nicklaus Turbo Golf (US).cue │ │ │ │ │ ├───Jessie Jaeger in Cleopatras Curse (US) │ │ │ Jessie Jaeger in Cleopatras Curse (US).bin │ │ │ Jessie Jaeger in Cleopatras Curse (US).cue │ │ │ │ │ ├───Jim Power in Mutant Planet (JP) │ │ │ Jim Power in Mutant Planet (JP).bin │ │ │ Jim Power in Mutant Planet (JP).cue │ │ │ │ │ ├───John Madden Duo CD Football (US) │ │ │ John Madden Duo CD Football (US).bin │ │ │ John Madden Duo CD Football (US).cue │ │ │ │ │ ├───Last Alert (US) │ │ │ Last Alert (US).bin │ │ │ Last Alert (US).cue │ │ │ │ │ ├───Lemmings (JP) │ │ │ Lemmings (JP).bin │ │ │ Lemmings (JP).cue │ │ │ │ │ ├───Loom (US) │ │ │ Loom (US).bin │ │ │ Loom (US).cue │ │ │ │ │ ├───Lords of the Rising Sun (US) │ │ │ Lords of the Rising Sun (US).bin │ │ │ Lords of the Rising Sun (US).cue │ │ │ │ │ ├───Lords of Thunder (US) │ │ │ Lords of Thunder (US).bin │ │ │ Lords of Thunder (US).cue │ │ │ │ │ ├───Magical Dinosaur Tour (US) │ │ │ Magical Dinosaur Tour (US).bin │ │ │ Magical Dinosaur Tour (US).cue │ │ │ │ │ ├───Meteor Blaster DX (US) │ │ │ Meteor Blaster DX (US).bin │ │ │ Meteor Blaster DX (US).cue │ │ │ │ │ ├───Might and Magic 3 - Isles of Terra (US) │ │ │ Might and Magic 3 - Isles of Terra (US).bin │ │ │ Might and Magic 3 - Isles of Terra (US).cue │ │ │ │ │ ├───Mirai Shounen Conan (JP) │ │ │ Mirai Shounen Conan (JP).bin │ │ │ Mirai Shounen Conan (JP).cue │ │ │ │ │ ├───Monster Lair (US) │ │ │ Monster Lair (US).bin │ │ │ Monster Lair (US).cue │ │ │ │ │ ├───Motoroader MC (JP) │ │ │ Motoroader MC (JP).bin │ │ │ Motoroader MC (JP).cue │ │ │ │ │ ├───Motteke Tamago (JP) (US) │ │ │ Motteke Tamago (JP) (US).bin │ │ │ Motteke Tamago (JP) (US).cue │ │ │ │ │ ├───Mysterious Song (US) │ │ │ Mysterious Song (US).bin │ │ │ Mysterious Song (US).cue │ │ │ │ │ ├───Neo Nectaris (JP) │ │ │ Neo Nectaris (JP).bin │ │ │ Neo Nectaris (JP).cue │ │ │ │ │ ├───Ookami-teki Monshou - Crest of Wolf (JP) │ │ │ Ookami-teki Monshou - Crest of Wolf (JP).bin │ │ │ Ookami-teki Monshou - Crest of Wolf (JP).cue │ │ │ │ │ ├───Police Connection (JP) │ │ │ Police Connection (JP).bin │ │ │ Police Connection (JP).cue │ │ │ │ │ ├───Pop n Magic (JP) │ │ │ Pop n Magic (JP).bin │ │ │ Pop n Magic (JP).cue │ │ │ │ │ ├───Populous - The Promised Lands (JP) │ │ │ Populous - The Promised Lands (JP).bin │ │ │ Populous - The Promised Lands (JP).cue │ │ │ │ │ ├───Prince of Persia (US) │ │ │ Prince of Persia (US).bin │ │ │ Prince of Persia (US).cue │ │ │ │ │ ├───Puyo Puyo CD (JP) │ │ │ Puyo Puyo CD (JP).bin │ │ │ Puyo Puyo CD (JP).cue │ │ │ │ │ ├───Pyramid Plunder (US) │ │ │ Pyramid Plunder (US).cue │ │ │ Pyramid Plunder (USA) (Unl).bin │ │ │ │ │ ├───Rainbow Islands - The Story of Bubble Bobble 2 (JP) │ │ │ Rainbow Islands - The Story of Bubble Bobble 2 (JP).bin │ │ │ Rainbow Islands - The Story of Bubble Bobble 2 (JP).cue │ │ │ │ │ ├───Rally Championship (JP) │ │ │ Rally Championship (JP).bin │ │ │ Rally Championship (JP).cue │ │ │ │ │ ├───Revival Chase (US) │ │ │ Revival Chase (US).bin │ │ │ Revival Chase (US).cue │ │ │ │ │ ├───Riot Zone (US) │ │ │ Riot Zone (US).bin │ │ │ Riot Zone (US).cue │ │ │ │ │ ├───Road Spirits (JP) │ │ │ Road Spirits (JP).bin │ │ │ Road Spirits (JP).cue │ │ │ │ │ ├───R-Type Complete CD (JP) │ │ │ R-Type Complete CD (JP).bin │ │ │ R-Type Complete CD (JP).cue │ │ │ │ │ ├───Shadow of the Beast │ │ │ Shadow of the Beast (US).bin │ │ │ Shadow of the Beast (US).cue │ │ │ │ │ ├───Shape Shifter │ │ │ Shape Shifter (US).bin │ │ │ Shape Shifter (US).cue │ │ │ │ │ ├───Sherlock Holmes - Consulting Detective - Volume 2 │ │ │ Sherlock Holmes - Consulting Detective - Volume 2 (US).bin │ │ │ Sherlock Holmes - Consulting Detective - Volume 2 (US).cue │ │ │ │ │ ├───Sherlock Holmes - Consulting Detective (US) │ │ │ Sherlock Holmes - Consulting Detective (US).cue │ │ │ Sherlock Holmes - Consulting Detective (USA).bin │ │ │ │ │ ├───SimEarth - The Living Planet │ │ │ SimEarth - The Living Planet (US).bin │ │ │ SimEarth - The Living Planet (US).cue │ │ │ │ │ ├───Slot Gambler │ │ │ Slot Gambler (JP).bin │ │ │ Slot Gambler (JP).cue │ │ │ │ │ ├───Splash Lake (US) │ │ │ Splash Lake (US).bin │ │ │ Splash Lake (US).cue │ │ │ │ │ ├───Star Parodier (JP) (US) │ │ │ Star Parodier (JP) (US).bin │ │ │ Star Parodier (JP) (US).cue │ │ │ │ │ ├───Startling Odyssey 2 - Maryuu Sensou (JP) (US) │ │ │ Startling Odyssey 2 - Maryuu Sensou (JP) (US).bin │ │ │ Startling Odyssey 2 - Maryuu Sensou (JP) (US).cue │ │ │ │ │ ├───Startling Odyssey 2 (JP) (US) │ │ │ Startling Odyssey 2 (JP) (US).bin │ │ │ Startling Odyssey 2 (JP) (US).cue │ │ │ │ │ ├───Super Air Zonk - Rockabilly-Paradise │ │ │ Super Air Zonk - Rockabilly-Paradise (US).bin │ │ │ Super Air Zonk - Rockabilly-Paradise (US).cue │ │ │ │ │ ├───Super Daisenryaku │ │ ├───SydMead TerraForming │ │ │ SydMead TerraForming (US).bin │ │ │ SydMead TerraForming (US).cue │ │ │ │ │ ├───The Addams Family (US) │ │ │ Addams Family, The (USA).bin │ │ │ The Addams Family (US).cue │ │ │ │ │ ├───The Dynastic Hero │ │ │ The Dynastic Hero (US).bin │ │ │ The Dynastic Hero (US).cue │ │ │ │ │ ├───The Local Girls of Hawaii (US) │ │ │ Local Girls of Hawaii, The (USA) (Unl).bin │ │ │ The Local Girls of Hawaii (US).cue │ │ │ │ │ ├───The Manhole │ │ │ The Manhole (JP).bin │ │ │ The Manhole (JP).cue │ │ │ │ │ ├───Valis 2 │ │ │ Valis 2 (US).bin │ │ │ Valis 2 (US).cue │ │ │ │ │ ├───Valis 3 │ │ │ Valis 3 (US).bin │ │ │ Valis 3 (US).cue │ │ │ │ │ ├───Vasteel │ │ │ Vasteel (US).bin │ │ │ Vasteel (US).cue │ │ │ │ │ ├───Where in the World Is Carmen Sandiego │ │ │ Where in the World Is Carmen Sandiego (JP).bin │ │ │ Where in the World Is Carmen Sandiego (JP).cue │ │ │ │ │ ├───Ys 3 - Wanderers from Ys │ │ │ Ys 3 - Wanderers from Ys (US).bin │ │ │ Ys 3 - Wanderers from Ys (US).cue │ │ │ │ │ ├───Ys 4 The Dawn of Ys (JP) (dub) (US) │ │ │ Ys 4 The Dawn of Ys (JP) (dub) (US).bin │ │ │ Ys 4 The Dawn of Ys (JP) (dub) (US).cue │ │ │ │ │ ├───Ys 4 The Dawn of Ys (JP) (US) │ │ │ Ys 4 The Dawn of Ys (JP) (US).bin │ │ │ Ys 4 The Dawn of Ys (JP) (US).cue │ │ │ │ │ ├───Ys Book 1 and 2 (US) │ │ │ Ys Book 1 and 2 (US).bin │ │ │ Ys Book 1 and 2 (US).cue │ │ │ │ │ └───Zero 4 Champ 2 │ │ Zero 4 Champ 2 (JP).bin │ │ Zero 4 Champ 2 (JP).cue │ │ │ ├───2 Unlicensed │ │ ├───Mysterious Song (US) │ │ │ Mysterious Song (US).bin │ │ │ Mysterious Song (US).cue │ │ │ │ │ └───Pyramid Plunder (US) │ │ Pyramid Plunder (US).cue │ │ Pyramid Plunder (USA) (Unl).bin │ │ │ ├───3 Translations │ │ ├───Akumajou Dracula X - Chi No Rondo (English v1.01) │ │ │ Akumajou Dracula X - Chi No Rondo (English v1.01).bin │ │ │ Akumajou Dracula X - Chi No Rondo (English v1.01).cue │ │ │ │ │ ├───Ginga Ojousama Densetsu Yuna (English v1.0) │ │ │ Ginga Ojousama Densetsu Yuna (English v1.0).bin │ │ │ Ginga Ojousama Densetsu Yuna (English v1.0).cue │ │ │ │ │ ├───Motteke Tamago (English v1.0) │ │ │ Motteke Tamago (English v1.0).bin │ │ │ Motteke Tamago (English v1.0).cue │ │ │ │ │ ├───Startling Odyssey II (English)[TruMisery] │ │ │ Startling Odyssey II (English)[TruMisery].bin │ │ │ Startling Odyssey II (English)[TruMisery].cue │ │ │ │ │ └───Ys IV - The Dawn of Ys (English Text + Dub) │ │ Ys IV - The Dawn of Ys (English Text + Dub).bin │ │ Ys IV - The Dawn of Ys (English Text + Dub).cue │ │ │ └───4 Hacks │ │ │ ├───Cosmic Fantasy 2 - Un-Worked Designs (Hack v0) │ │ Cosmic Fantasy 2 - Un-Worked Designs (Hack v0).bin │ │ Cosmic Fantasy 2 - Un-Worked Designs (Hack v0).cue │ │ │ ├───Exile - Un-Worked Designs (Hack v0) │ │ Exile - Un-Worked Designs (Hack v0).bin │ │ Exile - Un-Worked Designs (Hack v0).cue │ │ │ ├───Exile II - Un-Worked Designs (Hack v1) │ │ Exile II - Un-Worked Designs (Hack v1).bin │ │ Exile II - Un-Worked Designs (Hack v1).cue │ │ │ └───FX-Unit Yuki - The Henshin Engine │ FX-Unit Yuki - The Henshin Engine.bin │ FX-Unit Yuki - The Henshin Engine.cue │ └───Mazamars312.PC Engine CD │ Mazamars312.PC Engine CD.rar │ mpu.bin │ ├───1 Licensed │ │ Akumajou Dracula X - Chi no Rondo (JP) (US).json │ │ Baby Jo - The Super Hero (JP).json │ │ Beyond Shadowgate (US).json │ │ Black Hole Assault (JP).json │ │ Bonk 3 - Bonk Big Adventure (US).json │ │ Buster Bros (US).json │ │ Camp California (US).json │ │ Cosmic Fantasy 2 (US).json │ │ Cotton Fantastic Night Dreams (JP).json │ │ Dragon Slayer - The Legend of Heroes (US).json │ │ Dungeon Explorer 2 (US).json │ │ Dungeon Master - Therons Quest (US).json │ │ Exile - Wicked Phenomenon (US).json │ │ Exile (US).json │ │ F1 Circus Special - Pole to Win (JP).json │ │ Faceball (JP).json │ │ Fantastic Night Dreams - Cotton (US).json │ │ Final Zone 2 (US).json │ │ Forgotten Worlds (US).json │ │ FX Unit Yuki - The Henshin Engine (US).json │ │ Gate of Thunder (JP).json │ │ Gate of Thunder + Bonks Adventure + Bonks Revenge (US).json │ │ Godzilla (US).json │ │ Golden Axe (JP).json │ │ Hawaiian Island Girls (US).json │ │ Hypernova Blast (US).json │ │ Implode (US).json │ │ Insanity (US).json │ │ It Came from the Desert (US).json │ │ J. B. Harold Murder Club (US).json │ │ Jack Nicklaus Turbo Golf (US).json │ │ Jessie Jaeger in Cleopatras Curse (US).json │ │ Jim Power in Mutant Planet (JP).json │ │ John Madden Duo CD Football (US).json │ │ Last Alert (US).json │ │ Lemmings (JP).json │ │ Loom (US).json │ │ Lords of the Rising Sun (US).json │ │ Lords of Thunder (US).json │ │ Magical Dinosaur Tour (US).json │ │ Meteor Blaster DX (US).json │ │ Might and Magic 3 - Isles of Terra (US).json │ │ Mirai Shounen Conan (JP).json │ │ Monster Lair (US).json │ │ Motoroader MC (JP).json │ │ Motteke Tamago (JP) (US).json │ │ Mysterious Song (US).json │ │ Neo Nectaris (JP).json │ │ Ookami-teki Monshou - Crest of Wolf (JP).json │ │ Police Connection (JP).json │ │ Pop n Magic (JP).json │ │ Populous - The Promised Lands (JP).json │ │ Prince of Persia (US).json │ │ Puyo Puyo CD (JP).json │ │ Pyramid Plunder (US).json │ │ Rainbow Islands - The Story of Bubble Bobble 2 (JP).json │ │ Rally Championship (JP).json │ │ Revival Chase (US).json │ │ Riot Zone (US).json │ │ Road Spirits (JP).json │ │ R-Type Complete CD (JP).json │ │ Sherlock Holmes - Consulting Detective (US).json │ │ Splash Lake (US).json │ │ Star Parodier (JP) (US).json │ │ Startling Odyssey 2 - Maryuu Sensou (JP) (US).json │ │ Startling Odyssey 2 (JP) (US).json │ │ The Addams Family (US).json │ │ The Local Girls of Hawaii (US).json │ │ Ys 4 The Dawn of Ys (JP) (dub) (US).json │ │ Ys 4 The Dawn of Ys (JP) (US).json │ │ Ys Book 1 and 2 (US).json │ │ │ ├───Shadow of the Beast │ │ Shadow of the Beast (US).json │ │ │ ├───Shape Shifter │ │ Shape Shifter (US).json │ │ │ ├───Sherlock Holmes - Consulting Detective - Volume 2 │ │ Sherlock Holmes - Consulting Detective - Volume 2 (US).json │ │ │ ├───SimEarth - The Living Planet │ │ SimEarth - The Living Planet (US).json │ │ │ ├───Slot Gambler │ │ Slot Gambler (JP).json │ │ │ ├───Super Air Zonk - Rockabilly-Paradise │ │ Super Air Zonk - Rockabilly-Paradise (US).json │ │ │ ├───SydMead TerraForming │ │ SydMead TerraForming (US).json │ │ │ ├───The Dynastic Hero │ │ The Dynastic Hero (US).json │ │ │ ├───The Manhole │ │ The Manhole (JP).json │ │ │ ├───Valis 2 │ │ Valis 2 (US).json │ │ │ ├───Valis 3 │ │ Valis 3 (US).json │ │ │ ├───Vasteel │ │ Vasteel (US).json │ │ │ ├───Where in the World Is Carmen Sandiego │ │ Where in the World Is Carmen Sandiego (JP).json │ │ │ ├───Ys 3 - Wanderers from Ys │ │ Ys 3 - Wanderers from Ys (US).json │ │ │ └───Zero 4 Champ 2 │ Zero 4 Champ 2 (JP).json │ ├───2 Unlicensed │ Mysterious Song (US).json │ Pyramid Plunder (US).json │ ├───3 Translations │ Akumajou Dracula X - Chi No Rondo (English v1.01).json │ Ginga Ojousama Densetsu Yuna (English v1.0).json │ Motteke Tamago (English v1.0).json │ Startling Odyssey II (English)[TruMisery].json │ Ys IV - The Dawn of Ys (English Text + Dub).json │ └───4 Hacks Cosmic Fantasy 2 - Un-Worked Designs (Hack v0).json Exile - Un-Worked Designs (Hack v0).json Exile II - Un-Worked Designs (Hack v1).json FX-Unit Yuki - The Henshin Engine.json
lunchpacked130 commented 3 months ago

Seems my attempt at spoiler text made it pretty ineligible, so ill upload them as text files instead

Pupdate Log

Folder Structure

mattpannella commented 3 months ago

it's supposed to create the jsons files in a structure that mirrors your source files so if you have a folder Action and inside it 4 folders, one per game the jsons would get put into a folder named Action

is this what your issue is with? or is that just not functioning properly lol

lunchpacked130 commented 3 months ago

it's supposed to create the jsons files in a structure that mirrors your source files so if you have a folder Action and inside it 4 folders, one per game the jsons would get put into a folder named Action

is this what your issue is with? or is that just not functioning properly lol

edit: ignore this post and see my below post instead!

obsolete post It mirrors everything *except* jsons for games S-Z in my "1 Licensed" folder which gets put into subfolders with the game names. I can't see any reason why it should do this to only those games, as I've merged the bins into a single bin. The cue files for those games are identical to other games working (except for the filenames of course) so they should be handled the same way. Also, jsons in my folder "3 Translations" have 2 games starting with S and Y respectively, and those are not put into a subfolder during json generation, so i don't think it's just a simple "wrong settings for filenames starting with S through Z" Though that's just an assumption, and i can be mistaken. It makes those subfolders everytime ot generates jsons, even if I've copied those jsons together with the others.
lunchpacked130 commented 3 months ago

I think i found and solved the issue.. I was going over the files again to take screenshots, when i noticed some s-z games where sorted correctly. I then noticed that all the games that get jsons put into subfolder does not have (**) at the end..

To test if that made a difference, i deleted the "Shadow of the Beast" folder and json, and in "common/1 Licensed" , i renamed the folder "Shadow of the Beast" to "Shadow of the Beast (US)", matching the name of the the bin-cue files within, and ran update all..

Lo and behold, it now sorted correctly, so i added (US) & (JP) to the rest, so folders match the exact name of the bin-cues, then deleted and regenerated the jsons, and it now sorts 100% correctly, without putting any games into unwanted subfolders.

So my uneducated guess is it probably expects the folder and bin-cue names within to be similar, or maybe it expects the (**) at the end of the folder

To recreate this issue, try renaming the bin-cue folders to not match the files within and delete-regenerate jsons.

(Note. Renaming the bin-cue files is not adviced unless you also make sure the cue file is correctly updated as well)

mattpannella commented 3 months ago

huh, thanks for figuring out the steps to reproduce the bug for me! if i have some time today i'll take a look into why it's happening

mattpannella commented 3 months ago

ok yeah i was able to reproduce it. when the cue file name doesn't match the folder name it's inside, the json gets buried in an extra folder matching the original folder name. i'll try and get it fixed tonight

lunchpacked130 commented 3 months ago

Excellent! Glad i could help :) It's not a huge issue, as games still work, even if manually sorted afterwards, but i guess this would also fix @TheSKARD1 original naming issue, and avoid any confusion to why some game jsons get put into subfolders.

mattpannella commented 3 months ago

sorry I haven't had a chance to work on this yet. I'll get to it soon

mattpannella commented 2 months ago

pushing a build that should fix this

TheSKARD1 commented 1 month ago

Testing...

I have this disc image. .\Assets\pcecd\common\USA CD\The Addams Family (USA)\Addams Family, The (USA).cue

I get this json file. .\Assets\pcecd\Mazamars312.PC Engine CD\USA CD\Addams Family, The (USA).json

I expected this json file. .\Assets\pcecd\Mazamars312.PC Engine CD\USA CD\The Addams Family (USA).json

Results... They have the correct folder structure now. They are still named after the image and not the containing folder.

mattpannella commented 1 month ago

the file being named after the bin is how it's intended to work the core owner sets which file is used as the source for the name

see here https://github.com/Mazamars312/openfpga-pcengine-cd/blob/68f68c9a11a2453e03ef466e890684580b19a712/dist/Cores/Mazamars312.PC%20Engine%20CD/instance-packager.json#L14

TheSKARD1 commented 1 month ago

From the readme Each game needs to be in its own directory (and be sure to name the directory the full title of the game)

Why be sure to name the directory the full title of the game if the name of the directory isn't the one used?

mattpannella commented 1 month ago

if there is no "as_filename" in the config for the core it falls back to using the directory name instructions could be more clear we designed this to be used in multiple cores but it only ended up needing to be used for pcecd (and soon wont be) so its a bit half baked

mattpannella commented 1 month ago

try editing /Cores/Mazamars312.PC Engine CD/instance-packager.json and deleting the "as_filename" line and saving it now when you run the json builder it should use the foldername instead of the cue file

TheSKARD1 commented 1 month ago

Yep, that gave me the json file names I expected.

mattpannella commented 1 month ago

great!