Closed TheSKARD1 closed 2 months ago
I think i have a similar issue..
All games alphabetically from "Shadow of the beast" gets put in its own folder, but all games before is where they should be.
But I will double check just to be sure, I'll come back with any findings
I backed up all the jsons and deleted them, then ran update all to have it generate the jsons from scratch.
I can confirm that some generated jsons gets put into folders for some reason. i do have a customized folder layout for the roms, but it works with everrthing else. but for me, every game in my "1 Licensed" folder from "Shadow of the Beast" to "Zero 4 Champ 2" gets each put into a subfolder.
pupdate does not show any indication of generating some jsons inside folders.
below are the log from pupdate (truncated to just PCE CD) and a text representation of my PCE CD "Asset" folder structure:
Seems my attempt at spoiler text made it pretty ineligible, so ill upload them as text files instead
it's supposed to create the jsons files in a structure that mirrors your source files so if you have a folder Action and inside it 4 folders, one per game the jsons would get put into a folder named Action
is this what your issue is with? or is that just not functioning properly lol
it's supposed to create the jsons files in a structure that mirrors your source files so if you have a folder Action and inside it 4 folders, one per game the jsons would get put into a folder named Action
is this what your issue is with? or is that just not functioning properly lol
edit: ignore this post and see my below post instead!
I think i found and solved the issue.. I was going over the files again to take screenshots, when i noticed some s-z games where sorted correctly. I then noticed that all the games that get jsons put into subfolder does not have (**) at the end..
To test if that made a difference, i deleted the "Shadow of the Beast" folder and json, and in "common/1 Licensed" , i renamed the folder "Shadow of the Beast" to "Shadow of the Beast (US)", matching the name of the the bin-cue files within, and ran update all..
Lo and behold, it now sorted correctly, so i added (US) & (JP) to the rest, so folders match the exact name of the bin-cues, then deleted and regenerated the jsons, and it now sorts 100% correctly, without putting any games into unwanted subfolders.
So my uneducated guess is it probably expects the folder and bin-cue names within to be similar, or maybe it expects the (**) at the end of the folder
To recreate this issue, try renaming the bin-cue folders to not match the files within and delete-regenerate jsons.
(Note. Renaming the bin-cue files is not adviced unless you also make sure the cue file is correctly updated as well)
huh, thanks for figuring out the steps to reproduce the bug for me! if i have some time today i'll take a look into why it's happening
ok yeah i was able to reproduce it. when the cue file name doesn't match the folder name it's inside, the json gets buried in an extra folder matching the original folder name. i'll try and get it fixed tonight
Excellent! Glad i could help :) It's not a huge issue, as games still work, even if manually sorted afterwards, but i guess this would also fix @TheSKARD1 original naming issue, and avoid any confusion to why some game jsons get put into subfolders.
sorry I haven't had a chance to work on this yet. I'll get to it soon
pushing a build that should fix this
Testing...
I have this disc image. .\Assets\pcecd\common\USA CD\The Addams Family (USA)\Addams Family, The (USA).cue
I get this json file. .\Assets\pcecd\Mazamars312.PC Engine CD\USA CD\Addams Family, The (USA).json
I expected this json file. .\Assets\pcecd\Mazamars312.PC Engine CD\USA CD\The Addams Family (USA).json
Results... They have the correct folder structure now. They are still named after the image and not the containing folder.
the file being named after the bin is how it's intended to work the core owner sets which file is used as the source for the name
From the readme Each game needs to be in its own directory (and be sure to name the directory the full title of the game)
Why be sure to name the directory the full title of the game if the name of the directory isn't the one used?
if there is no "as_filename" in the config for the core it falls back to using the directory name instructions could be more clear we designed this to be used in multiple cores but it only ended up needing to be used for pcecd (and soon wont be) so its a bit half baked
try editing /Cores/Mazamars312.PC Engine CD/instance-packager.json and deleting the "as_filename" line and saving it now when you run the json builder it should use the foldername instead of the cue file
Yep, that gave me the json file names I expected.
great!
Not a technical bug, I wanted to share my experience in the hope something can be improved.
Describe the bug In my pcecd common folder I have the bin/cue images in individual folders for each game. The image names do not match the folder name. The folder name is how I want the title displayed.
After running pupdate.exe and generating the json files I get the following: 4 were in the main folder. These 4 are the only ones where the image name matched the folder name. Everything else was in individual folders for each game matching my game title folders. The json files in the individual folders were named with the image name.
I wrote for myself a batch file to rename all of them to their folder name. Then I moved them into the main folder and deleted the subfolders.
Expected behavior Name json files after the folder name. Have all json files in the same folder.