search

mattpannella / pupdate

Pupdate - A thing for updating your Analogue Pocket
https://mattpannella.github.io/pupdate/
MIT License
989 stars 33 forks source link

"Download Missing Assets during 'Update All'" also blocks "Download Assets" #301

Closed bevans10037 closed 1 month ago

bevans10037 commented 1 month ago

Describe the bug When the "Download Missing Assets (ROMs and BIOS Files) during 'Update All'" setting is turned off, the assets will also not be downloaded when "3 - Download Assets" is selected.

To Reproduce Steps to reproduce the behavior: From a blank pupdate_settings.json, go to the settings, turn off "Download Missing Assets...", reboot the program (it will still download assets before rebooting), then select "3 - Download Assets"

Expected behavior Assets should only not be downloaded specifically in "0 - Update All"; "3 - Download Assets" should be ok I reckon, since you're explicitly asking to download the assets

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Contents of settings file please attach the contents of pupdate_settings.json pupdate_settings.json

mattpannella commented 1 month ago

woops, i wonder when i broke this

mattpannella commented 1 month ago

this should be fixed in the latest release