mattpannella / pupdate

Pupdate - A thing for updating your Analogue Pocket
https://mattpannella.github.io/pupdate/
MIT License
1.12k stars 38 forks source link

Jotego Core(s) or at least XMen not showing up #361

Open ReanimationXP opened 1 week ago

ReanimationXP commented 1 week ago

Describe the bug Even with a new, clean run of pupdate, and after adding my jotego key to the root where pupdate lives, it is processing and downloading Jotego cores, but certain ones like XMen Arcade don't appear anywhere in the menu. The Xmen rom and core seem to be downloading and processing correctly, but they don't appear in the menu anywhere. I am not sure which files dictate what appears in the menu and what doesn't.. perhaps this is an issue with the Jotego core renaming function.. I could not quickly find a reference to Xmen in the github code, so perhaps it is not supported yet?

To Reproduce Steps to reproduce the behavior:

  1. Start a completely new pupdate folder.
  2. Run pupdate, add a jotego beta key, and a coinop beta email into the settings. Set other settings as follows if necessary: image
  3. Exit pupdate, relaunch it, and update all.
  4. Look for Xmen in the OpenFPGA menu. For me, it does not appear.

Expected behavior XMen should appear in the OpenFPGA menu somewhere.

Screenshots see above

Desktop (please complete the following information):

Contents of settings file

{
  "config": {
    "download_assets": true,
    "github_token": null,
    "download_firmware": true,
    "preserve_platforms_folder": false,
    "delete_skipped_cores": true,
    "download_new_cores": "ask",
    "display_modes_option": "ask",
    "build_instance_jsons": true,
    "crc_check": true,
    "fix_jt_names": true,
    "skip_alternative_assets": true,
    "backup_saves": true,
    "backup_saves_location": "Backups",
    "show_menu_descriptions": true,
    "use_custom_archive": true,
    "auto_install_updates": false,
    "coin_op_beta": true,
    "temp_directory": null,
    "patreon_email_address": "reanimationxp@gmail.com",
    "add_display_mode_description_to_video_json": true,
    "use_local_pocket_extras": false,
    "use_local_display_modes": false,
    "archives": [
      {
        "name": "default",
        "type": "internet_archive",
        "archive_name": "openFPGA-Files"
      },
      {
        "name": "custom",
        "type": "custom_archive",
        "archive_name": "custom",
        "url": "https://updater.retrodriven.com",
        "index": "updater.php"
      },
      {
        "name": "agg23.GameAndWatch",
        "type": "core_specific_archive",
        "archive_name": "fpga-gnw-opt",
        "file_extensions": [
          ".gnw"
        ],
        "enabled": false
      }
    ]
  },
  "core_settings": {
    "Spiritualized.Adventurevision": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Mazamars312.Amiga": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.Arcadia": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "agg23.Arduboy": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "ericlewis.Asteroids": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.7800": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.2600": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "boogermann.bankpanic": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "pram0d.batrider": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "pram0d.bakraid": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "pram0d.garegga": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.ChannelF": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.Coleco": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "boogermann.congo": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.Creativision": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "boogermann.digdug": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "ericlewis.Dominos": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "ericlewis.DonkeyKong": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "antongale.exerion": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "somhi.flappybird": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "boogermann.galaga": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.Gamate": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "agg23.GameAndWatch": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.GB": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.GBA": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.GBC": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.GG": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.Gameking": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "ericlewis.Genesis": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.Genesis": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "boogermann.gberet": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.Intv": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtbtiger": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtcastle": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtcomsc": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtcontra": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtcop": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtcps1": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtdd": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtdd2": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtexed": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtgng": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtgunsmk": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtkarnov": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtkicker": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtkiwi": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtkunio": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtmikie": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtoutrun": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtpang": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtpinpon": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtrastan": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtroadf": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtroc": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtsarms": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtsbaskt": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtsectnz": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtsf": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jttrack": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jttrojan": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtvigil": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtvulgus": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtyiear": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "pram0d.kingdmgp": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "ericlewis.LunarLander": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.SMS": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.Megaduck": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Mazamars312.NeoGeo": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Mazamars312.NeoGeo_Overdrive": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.NES": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "agg23.NES": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.Odyssey2": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "agg23.PC Engine": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Mazamars312.PC Engine CD": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spacemen3.PDP1": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "antongale.performan": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "agg23.PokemonMini": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "agg23.Pong": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "boogermann.pooyan": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "ericlewis.QBert": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "ericlewis.RadarScope": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.SG-1000": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "antongale.slapfight": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "agg23.SNES": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "pram0d.snowbros2": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "pram0d.sstriker": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "ericlewis.SpaceRace": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.Studio2": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "ericlewis.SuperBreakout": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.SuperGB": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "boogermann.supervision": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.Supervision": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "antongale.taitosj": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "agg23.Tamagotchi_P1": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "nullobject.tecmo": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Spiritualized.VideoBrain": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "agg23.WonderSwan": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "boogermann.xevious": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "agg23.NES_Analogizer": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "agg23.PC Engine_Analogizer": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "agg23.SNES_Analogizer": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "atrac17.combatribes": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "atrac17.pipibibs": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "atrac17.tekipaki": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "atrac17.truxton2": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "AwesomeDolphin.SpaceInvaders": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "budude2.GB": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "budude2.GBC": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "budude2.Lynx": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "ericlewis.Genesis_Analogizer": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jt1942": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jt1943": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtaliens": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtbiocom": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtbubl": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtcircus": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtcommnd": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtcps15": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtcps2": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtflane": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtfround": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtkchamp": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtlabrun": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtmidres": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtmx5k": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtngp": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtngpc": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true,
      "requires_license": true
    },
    "jotego.jtninja": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtparoda": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtriders": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true,
      "requires_license": true
    },
    "jotego.jtrumble": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jts16": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jts16b": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jts18": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true,
      "requires_license": true
    },
    "jotego.jtshanon": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtshouse": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtsimson": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtslyspy": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jttmnt": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jttoki": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jttora": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtwwfss": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "markus-zzz.MyC64": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "Mazamars312.NeoGeo_Analogizer": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "Mazamars312.PC Engine CD_Analogizer": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "obsidian.AsteroidsDeluxe": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "obsidian.Defender": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "obsidian.DonkeyKong3": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "obsidian.DonkeyKongJr": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "obsidian.Druaga": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "obsidian.Gaplus": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "obsidian.Gauntlet": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "obsidian.Gauntlet_Analogizer": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "obsidian.Joust2": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "obsidian.MarioBros": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "obsidian.Robotron": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "obsidian.System1": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "obsidian.System1_Analogizer": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "obsidian.Vectrex": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "opengateware.irem_m92": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "opengateware.irem_m92_Analogizer": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "pram0d.doubledragoniii": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "pram0d.narc": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true,
      "requires_license": true
    },
    "pram0d.smashtv": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true,
      "requires_license": true
    },
    "pram0d.wrestlefest": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "RndMnkIII.alphamission": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "RndMnkIII.alphamission_Analogizer": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "rolandking.Athena": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "rolandking.Jailbreak": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "tsalvo.varvara": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "jotego.jtxmen": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true,
      "requires_license": true
    },
    "pram0d.mortalkombat": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true,
      "requires_license": true
    },
    "pram0d.totalcarnage": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true,
      "requires_license": true
    },
    "jotego.jtwc": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true,
      "requires_license": true
    },
    "antongale.slapfight_Analogizer": {
      "skip": true,
      "download_assets": true,
      "platform_rename": true
    },
    "boogermann.msx": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true
    },
    "pram0d.trog": {
      "skip": false,
      "download_assets": true,
      "platform_rename": true,
      "requires_license": true
    }
  }
}
mattpannella commented 1 week ago

what is the name of your jotego beta file?

ReanimationXP commented 1 week ago

jtbeta.zip. the core is being installed and whatnot, it's there.. just doesn't appear in the menu. maybe the json file(s) or the renaming function is messed up somehow?

BooBerry commented 1 week ago

It's something to do with the jtxmen.json Platform file being renamed/changed. If you use the original, unmodified jtxmen.json Platform file from JT's Patreon the core appears in the list and the game loads fine. I originally thought this issue was caused because of the - in the X-Men name, but if you rename the unmodified, original jtxmen.json name field inside from jtxmen to X-Men or even XMen it doesn't work. Any modification of the original file doesn't allow the core to show up in the list.

Not sure if this is some sort of weird .json file/syntax issue or a Pocket bug or a JT core bug or something else. But if you enable the setting to rename JT cores it'll cause X-Men to not appear because of this. You'll have to use the original, unmodified .json file to get it to appear for the time being.

ReanimationXP commented 1 week ago

Thanks for confirming it's not just me. Another user in coinop's discord claimed they had reformatted and the problem went away, but that makes no sense that it would. They obviously manually installed or left the Rename Jotego Cores function off.

mattpannella commented 1 week ago

sorry been busy so i haven't had a ton of time to focus on pupdate. the renaming thing is interesting. i'll try to see if i can figure out exactly what's going on as soon as i can

ReanimationXP commented 5 days ago

thank you! is there a log or anything for the renaming process I could review? is there perhaps a special character the firmware doesn't like? I think other titles like Total Carnage are also not showing up. I don't know why. It seems to be the new and/or beta stuff, but only seems to be some of it. SmashTV is fine.