Open mattphillips opened 1 year ago
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
e37b759
) to head (8a8138f
). Report is 3 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is a bit of a POC to add type definitions for each diff function that works correctly.
I've not exhaustively tested this yet so don't know if it covers all cases but the general idea is as follows:
diff
: Merge the left hand side and right hand side types into optionals at all levels and convert arrays to dictionaries (recursing on the inferred array element type)added
: Keep all new RHS keys and set all old LHS keys tonever
. All new new at any level should not be optional. Arrays can also have been inserted into so they should be kept in the types but made optional dictionaries.deleted
: Keep all keys that are not present on the RHS keys but exist in the LHS asundefined
. Arrays can also have been deleted from so they should be kept in the types but made optional dictionaries.updated
: TODO