search

mattpocock / pkg-demo

164 stars 37 forks source link

Fix missing changeset publish #5

Closed talves closed 1 year ago

talves commented 1 year ago

Publish will not happen without a changeset publish (npm publish) command. I've added a script called release and fixed the job to be called publish in publish.yml workflow.

Extra: I added a check for "CI" workflow completion on success along with checking for a push on main. This will make the publish workflow skip if the build or lint fail.

Thanks for the video and example. Nice demo.

mattpocock commented 1 year ago

Some very nice GitHub-fu! Love it, thanks.