search

mattpocock / pkg-demo

164 stars 37 forks source link

fixed publish workflow running in any branch and permission issues #6

Closed Juhan280 closed 7 months ago

Juhan280 commented 1 year ago

First of all, I want to thank you for your amazing video. It was very helpful.

However I ran into someone issues while following along.

First issue I faced was related to permission. I managed to fix it by specifying the required permissions in publish.yml file and granting pull request permission in repository settings.

The second issue I faced is that the publish workflow always gets triggered even though changes are not made in the main branch. The reason was Publish workflow gets triggered every time the CI workflow succeeds, but the CI workflow is triggered from any branches.

To fix that, I have added branches property to the workflow_run event.

And also, I have removed the push event because it was getting skipped because of the if statement. This event is no longer necessary since we have workflow_run event.

webspaceadam commented 1 year ago

Thanks so much for this PR. That helped :)

Would be cool to see it merged.

mattpocock commented 1 year ago

Looks great!