(fix): [engine] Improperly indexing into params map

mattpocock / ts-error-translator

VSCode extension to turn TypeScript errors into plain English

https://ts-error-translator.vercel.app

2.35k stars 90 forks source link

(fix): [engine] Improperly indexing into params map #270

Open dmmulroy opened 4 months ago

dmmulroy commented 4 months ago

In associateMatchedParameters we are indexing into the params map/object while iterating over the matchedParams by using params.parameter. This should actually be params[parameter]. All tests are still passing, so there seems to be no obvious regressions.

changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: 751b42de1b8cd9873aac906e0720b1e09b16af02

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

mattpocock commented 4 months ago

Good catch!