Video/Audio Machine - Githubissues

mattpocock / xstate-catalogue

Professionally designed, interactive state machines

https://xstate-catalogue.com

MIT License

811 stars 62 forks source link

Video/Audio Machine #51

Open leonardomso opened 3 years ago

leonardomso commented 3 years ago

As discussed in the #47 issue, here's the pull request for the Video/Audio controls machine.

I still think there's a lot of room for improvement in this machine. I'd love to receive some feedback.

A few ideas that I think could be discussed:

Change the initial state of ready state for idle. There might be some use cases where people want to load the content but not auto-play it.
Add support for seek.
Add support for quality controls and subtitles as @mattpocock suggested.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mattpocock/xstate-catalogue/6jGjaLLpu8hsRMs8cQeYRdQDpqd2
✅ Preview: https://xstate-catalogue-git-fork-leonardomso-master-mattpocock.vercel.app

tomByrer commented 3 years ago

Thanks! Should the discussion be in this PR thread, or back in the Issue?

leonardomso commented 3 years ago

I think it would be fine if it was in this pull request. What are your thoughts about it so far, @tomByrer?

christianchown commented 2 years ago

What are your thoughts of putting the boolean context items in parallel states, as in https://xstate.js.org/viz/?gist=b9a8e4db654cea07fe2080bd56b6cdc7