search

mattpocock / xstate-codegen

A codegen tool for 100% TS type-safety in XState
MIT License
245 stars 12 forks source link

Bug rollup external file #20

Closed redappleorigin closed 4 years ago

redappleorigin commented 4 years ago

related to: #16 this fixes the issue of rollup treating absolute paths as external. credit to @rjdestigter for figuring out the issue and @mattpocock for providing the fix used in this pr.

changeset-bot[bot] commented 4 years ago

🦋 Changeset is good to go

Latest commit: e0b0bcf85ebd3bb7cb8fa46ae4de2a0159ceef61

We got this.

This PR includes changesets to release 1 package | Name | Type | | -------------- | ----- | | xstate-codegen | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

mattpocock commented 4 years ago

@Andarist could I get your thoughts on this? This fix should suffice until your TS work is hot to trot.

@redappleorigin 👏 👏 👏 👏 👏

rjdestigter commented 4 years ago

hot to trot

I'm taking that one to the market.

mattpocock commented 4 years ago

Merging and releasing this now.