search

mattpocock / xstate-codegen

A codegen tool for 100% TS type-safety in XState
MIT License
245 stars 12 forks source link

Zero exit code when no files matching #58

Closed danielkcz closed 3 years ago

danielkcz commented 3 years ago

No matching files shouldn't be considered an error. It's a problem in CI where some files are not available yet (due to Docker layering optimizations) and it would fail the build.

So far I've been dealing with that using --ignore-scripts flag. However, now I also need to run patch-package in postinstall so it's no longer an option.

changeset-bot[bot] commented 3 years ago

⚠️ No Changeset found

Latest commit: a8e21f8ae34e90787175bf1fcdfc34cff73bf856

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

mattpocock commented 3 years ago

@FredyC I agree with this. It doesn't affect anything in our toolchain so am happy to merge. Could you add a changeset?

danielkcz commented 3 years ago

This is now superseded by #59, so closing.