mattpodolak / pmaw

A multithread Pushshift.io API Wrapper for reddit.com comment and submission searches.
MIT License
213 stars 28 forks source link

Support for Pushshift switchover to COLO (as of 2022-12) #50

Closed Dominyk4s closed 1 year ago

Dominyk4s commented 1 year ago

Just a quick temporary fix TL;DR: Added two parameters: _sortvar and _checktotals to API calls; add variables sort_var='order', check_totals=False while calling search_submissions or any other function for it to work with the latest data in Pushshift

Longer version:

After moving to COLO (related Reddit post is here), The current wrapper stopped working. Known differences:

mattpodolak commented 1 year ago

hey @Dominyk4s, thanks for opening this PR! I'll review it today/tomorrow

mattpodolak commented 1 year ago

@Dominyk4s there was a similar PR that addressed a couple of the changes in the COLO switchover, can you review the conflicts?

Dominyk4s commented 1 year ago

@Dominyk4s there was a similar PR that addressed a couple of the changes in the COLO switchover, can you review the conflicts?

@mattpodolak, I reviewed another PR, which seems to solve the same thing, just with a different approach (changes the defaults there and I'm adding everything as variables here). And I see you moved forward with even more updates, so we can close this PR 😊