search

mattpolito / paratrooper

Library for creating tasks that deploy to Heroku
MIT License
107 stars 19 forks source link

Paratrooper skips migrations #41

Closed davidgoli closed 11 years ago

davidgoli commented 11 years ago

Under Paratrooper 1.4.2, deploy never manages to run migration on Heroku, so we always have to run them manually. I realize that 1.4.0 introduced "selective migrations", but I find that to be more of a bug than a feature. rake db:migrate already checks for pending migrations so adding code around that to diff the git repo is only going to introduce bugs like this one, and even when it works it's redundant to Rails' default behavior. I recommend that this feature be removed, or at least given a config option to bypass.

davidgoli commented 11 years ago

Even though the migration_check option is provided, it's not documented. A better option would be to just make it a boolean, when set to false the migration check is bypassed.

mattpolito commented 11 years ago

Thanks for the input @davidgoli. The reason skipping migrations was added was due to rake db:migrate re-instantiating the rails environment. This adds quite a bit of time to the deploy process when no migrations are there to run in the first place.

I am very open to suggestions if you have an idea on how to remedy the issue you're experiencing.

mattpolito commented 11 years ago

Closing as #42 has some work around this