mattpolito / paratrooper

Library for creating tasks that deploy to Heroku
MIT License
107 stars 19 forks source link

Add screen notification when custom callbacks are added #49

Closed mattpolito closed 10 years ago

mattpolito commented 10 years ago

When defining a custom callback like so:

Paratrooper::Deploy.new('amazing-app') do |deploy|
  deploy.add_callback(:before_setup) do
    # code to disable new relic
  end
end

There should be the ability to add in a screen notification of what is happening.

Maybe something like:

Paratrooper::Deploy.new('amazing-app') do |deploy|
  deploy.add_callback(:before_setup) do
    deploy.add_screen_notification("Disabling newrelic ping")
    # code to disable new relic
  end
end

Thoughts?

mwoods79 commented 10 years ago

How about something like this?

Paratrooper::Deploy.new('amazing-app') do |deploy|
  deploy.add_callback(:before_setup) do |output|
    output.puts("Disabling newrelic ping")
    # code to disable new relic
    output.puts("Yep, done did that!")
  end
end
mattpolito commented 10 years ago

@mwoods79 Thats pretty much the same as what @bthesorceror were discussing so that will probably be it. Previous screen notification will probably need to change a bit though. Thanks for the input.