search

mattpolito / paratrooper

Library for creating tasks that deploy to Heroku
MIT License
107 stars 19 forks source link

Undefined method `maintenance_mode=' #57

Closed pkuruppu closed 10 years ago

pkuruppu commented 10 years ago

rake deploy:staging works fine. rake deploy:production is giving me this error: https://gist.github.com/pkuruppu/44d8b6becad915ffeebf

To verify, here is my app's deploy.rake file: https://github.com/pkuruppu/flicker_app/blob/master/lib/tasks/deploy.rake

What do you guys think is going on?

mattpolito commented 10 years ago

maintenance_mode= was removed a bit ago but I believe there is a use case for it. I'll work on adding it back in.

With that being said, new versions of paratrooper are quite efficient on when to use maintenance_mode. Currently it will only use it if a migration is detected and needs to run. This will also change as there is no need to turn on maintenance mode for normal migrations that have additions.

The only time you'll really need to use it now is for a long running data migration or many row deletions.

Hope that helps. Let me know about your use case and I might be able to help you out more if needed.

knwang commented 10 years ago

I think we just need to remove it from the "example usage" in the documentation part.

mattpolito commented 10 years ago

@knwang that is what I was going to do but then realized there is a use case for it to actually be there. I'm going to be adding it back in so that it can be manually triggered.

mattpolito commented 10 years ago

documentation was removed in #58