mattpolito / paratrooper

Library for creating tasks that deploy to Heroku
MIT License
107 stars 19 forks source link

Invalid hostname when warming application #59

Closed tmaier closed 10 years ago

tmaier commented 10 years ago

My heroku app has two domains: example.herokuapp.com and *.example.com. Paratrooper seems to use the last one when warming the application.

I get the following error:

============================================================
>> Accessing *.example.com to warm up your application
============================================================

rake aborted!
URI::InvalidURIError: the scheme http does not accept registry part: *.example.com (or bad hostname?)
require 'uri'
URI('http://*.example.com')
# => URI::InvalidURIError: the scheme http does not accept registry part: *.example.com (or bad hostname?)
#    from /usr/local/opt/rbenv/versions/2.1.1/lib/ruby/2.1.0/uri/generic.rb:214:in `initialize'

Possible solutions:

knwang commented 10 years ago

@mattpolito do we need warming up apps? I am not sure the app is ever "cold" after deploy

mattpolito commented 10 years ago

Well, the idea was that you would hit the dyne the first time with the warmup call before your users would but that has not been the case. With the requests getting queued it appears that the warmup call a lot of times goes to the old dyne instead of the new one. I've been toying with the idea of removing it.