search

mattpolzin / JSONAPI

Swift Codable JSON:API framework
MIT License
75 stars 19 forks source link

Request: Carthage support #91

Closed russellyeo closed 3 years ago

russellyeo commented 3 years ago

Thanks for creating this library, the type-safe approach of the implementation is really nice!

Please consider adding support for Carthage to allow projects using Carthage as a dependency manager to integrate this library.

mattpolzin commented 3 years ago

Thanks for the suggestion. This is something I've been resistant to because it's one more thing that needs to be maintained and in this case it means tying this project to Xcode (and the changes that come to Xcode with new versions) whereas it currently only depends on the versions of Swift that are supported.

I should probably add a section to the README on Carthage so folks don't need to wonder why it isn't there.

I briefly explained a way for motivated individuals to fork the repo and add Carthage support without too much effort here: https://github.com/mattpolzin/JSONAPI/issues/36

russellyeo commented 3 years ago

Fair enough, that makes sense. Thanks for your response and for sharing instructions for adding support to a fork.