mattpolzin / nix-idris2-packages

5 stars 1 forks source link

Use the LSP repo's Flake to build the LSP server #1

Closed mattpolzin closed 2 months ago

mattpolzin commented 2 months ago

Right now, the strategy the LSP server's flake uses has been copied into the overrides.nix so that the LSP server in the package set builds a functional executable. Instead, I think it would be better to treat the LSP server like Idris2 is treated: Update a flake.nix input to refer to the correct commit of the LSP repo for the given package set when running update.sh and then use that flake input by forcing it into the package set over the top of the existing idris2-lsp entry (or, for non-flake builds, pull the LSP explicitly based on the flake.lock entry).

mattpolzin commented 2 months ago

Closed by https://github.com/mattpolzin/nix-idris2-packages/commit/ee5791b761e7727005a8d5bf7ecec893fe1ed9f6